A cohort's reserve is the whole of its reservoir, not a part of it
Commit proved the destination reservoir existed and that the registry slot was free, but never that the reservoir was empty. Gathering into an occupied reservoir therefore succeeded and mixed inventory the conversion had never sampled into the cohort's backing store: the cohort's recorded reserve understated what backed it, and the surplus belonged to nobody. Reproduced against the unfixed code rather than taken on trust. Gathering into reservoir 5, which the fixture already seeds with seven picojoules, commits and leaves the ledger holding 67 against a cohort recording 60, exactly as reported. A destination holding anything is refused now. The success test also asserts the destination balance equals the installed cohort's reserve, so the equality is checked rather than assumed, and the regression asserts the refusal leaves the balances, the action counter and the registry as they were, then that emptying the reservoir first makes the same plan committable. The check runs after the staleness loop rather than beside the other destination checks. Both run before anything moves, so it is a reporting choice: replaying a committed plan into a fresh registry would be refused by either, and that the members no longer hold what was sampled says more than that the reservoir is occupied. The guard was confirmed load-bearing by removing it alone. An earlier attempt at that reported it as not load-bearing; that result was void and discarded, because a heredoc had mangled the mutation script and nothing was ever mutated. Second time this quirk has produced a false negative in a sweep, and both times the printed output rather than the exit status is what caught it. Release 35/35, analysis, ASan 35/35 and clang-format all ran and passed here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1027,3 +1027,37 @@ fingerprint `2cd4a15f9fbe9949`, the ensemble fingerprint `5ec59d390909b526` and
|
||||
the frozen genome fixture are unchanged, and the other 34 tests pass untouched.
|
||||
No deployment manifest or image pin changed. Linux validation is pending; no Gitea
|
||||
result is claimed since `b01a824`.
|
||||
|
||||
Review of `1a59b63` found one defect (2026-09-24), now fixed with a regression
|
||||
confirmed to fail against the unfixed code.
|
||||
|
||||
Commit proved the destination reservoir existed and that the registry slot was
|
||||
free, but never that the reservoir was empty. A conversion into an occupied
|
||||
reservoir therefore succeeded and mixed inventory it had never sampled into the
|
||||
cohort's backing store, leaving the cohort's recorded reserve understating what
|
||||
backed it and the surplus owned by nobody. The reported case was reproduced
|
||||
against the unfixed code rather than assumed: gathering into reservoir 5, which
|
||||
the fixture already seeds with seven picojoules, commits successfully and leaves
|
||||
the ledger holding 67 against a cohort recording 60.
|
||||
|
||||
A destination holding anything is now refused. The success test additionally
|
||||
asserts that the destination balance equals the installed cohort's reserve, so a
|
||||
cohort's reserve is the whole of its reservoir rather than a part of it, and the
|
||||
new regression asserts that the refusal leaves the ledger balances, the ledger
|
||||
action counter and the registry all exactly as they were, then that emptying the
|
||||
reservoir first makes the same plan committable.
|
||||
|
||||
The check runs after the staleness loop rather than beside the other destination
|
||||
checks. Both run before anything moves, so this is a reporting choice and not a
|
||||
safety one: replaying a committed plan into a fresh registry would be refused by
|
||||
either, and that the members no longer hold what was sampled is the more useful
|
||||
answer than that the reservoir is occupied. The ordering rationale is recorded
|
||||
beside the check.
|
||||
|
||||
The guard was confirmed load-bearing by removing it alone, which fails the new
|
||||
regression. An earlier attempt to add that mutation reported the guard as not
|
||||
load-bearing; the result was void and discarded, because a Bash heredoc had
|
||||
mangled the escaped newlines in the mutation script and the script failed to
|
||||
parse, so nothing was ever mutated. It is the second time this environment quirk
|
||||
has produced a false negative in a mutation sweep, and both times the printed
|
||||
output rather than the exit status is what revealed it.
|
||||
|
||||
Reference in New Issue
Block a user