From 082c7f9c33f6a7b50efcac0fa5b10f9992d1c140 Mon Sep 17 00:00:00 2001 From: dingo Date: Sun, 11 Oct 2026 18:23:09 -0400 Subject: [PATCH] Report typed client lifecycle open failures --- docs/engineering/VALIDATION.md | 2 ++ tests/client_lifecycle.cpp | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index 243d417..079ea17 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -7010,3 +7010,5 @@ CI run #303 stopped at the format gate on the SQLSTATE expression from the prece CI run #304 rejected both wrapped layouts of the SQLSTATE expression at the formatting gate. The complete statement is now joined onto one line (within the configured 100-column limit); CI must confirm the exact formatter output. CI run #305 passed formatting and most independent gates, but PostgreSQL clang-tidy rejected `site()` in `apps/evo-world-clone/main.cpp`: `string_view::data()` may be null for an empty view passed to `from_chars`. The parser now rejects an empty site argument before accessing its data. The dependent PostgreSQL tools and server-image/Harbor publication jobs did not run; CI must validate the guard and complete publication. + +CI run #306 passed formatting, deploy selection, ECS, and TSan, and built the PostgreSQL test targets. Its client lifecycle probe failed at `native_input()` while opening the SDL application (line 174); the test reported only the source line and an empty SDL error, so the startup error was not identifiable. It has been updated to report the typed application error and SDL initialization state. PostgreSQL static analysis was still running when this follow-up was prepared; Harbor publication did not start. diff --git a/tests/client_lifecycle.cpp b/tests/client_lifecycle.cpp index c27b889..7284a31 100644 --- a/tests/client_lifecycle.cpp +++ b/tests/client_lifecycle.cpp @@ -171,7 +171,11 @@ Intention required(std::expected result) { void native_input() { const auto frame = fixture(); auto result = Application::open({320, 240, false, "software"}); - CHECK(result); + if (!result) + throw std::runtime_error("native-input open failed error=" + + std::to_string(static_cast(result.error())) + + " SDL_WasInit=" + std::to_string(SDL_WasInit(0)) + + " SDL=" + SDL_GetError()); auto app = std::move(result.value()); CHECK(app->poll_events()); const auto id = SDL_GetWindowID(window());