From 11bff3169e1a113261755f241320c1e29ced0973 Mon Sep 17 00:00:00 2001 From: dingo Date: Sun, 11 Oct 2026 18:35:24 -0400 Subject: [PATCH] Report toolkit client startup failures --- docs/engineering/VALIDATION.md | 2 ++ tests/client_lifecycle.cpp | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index 079ea17..60b80f1 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -7012,3 +7012,5 @@ CI run #304 rejected both wrapped layouts of the SQLSTATE expression at the form CI run #305 passed formatting and most independent gates, but PostgreSQL clang-tidy rejected `site()` in `apps/evo-world-clone/main.cpp`: `string_view::data()` may be null for an empty view passed to `from_chars`. The parser now rejects an empty site argument before accessing its data. The dependent PostgreSQL tools and server-image/Harbor publication jobs did not run; CI must validate the guard and complete publication. CI run #306 passed formatting, deploy selection, ECS, and TSan, and built the PostgreSQL test targets. Its client lifecycle probe failed at `native_input()` while opening the SDL application (line 174); the test reported only the source line and an empty SDL error, so the startup error was not identifiable. It has been updated to report the typed application error and SDL initialization state. PostgreSQL static analysis was still running when this follow-up was prepared; Harbor publication did not start. + +CI run #307 passed the format/deploy/ECS/network/TSan gates. The instrumented `native_input()` open succeeded, but the next application open in `toolkit_capture()` failed (line 277 in that run), before PostgreSQL analysis completed; Harbor publication did not start. This second open now reports its typed error and SDL initialization state too, so the next run can distinguish an SDL window failure from toolkit initialization. diff --git a/tests/client_lifecycle.cpp b/tests/client_lifecycle.cpp index 7284a31..8402c6a 100644 --- a/tests/client_lifecycle.cpp +++ b/tests/client_lifecycle.cpp @@ -274,7 +274,11 @@ void native_input() { void toolkit_capture() { const auto frame = fixture(); auto result = Application::open({320, 240, false, "software"}); - CHECK(result); + if (!result) + throw std::runtime_error("toolkit-capture open failed error=" + + std::to_string(static_cast(result.error())) + + " SDL_WasInit=" + std::to_string(SDL_WasInit(0)) + + " SDL=" + SDL_GetError()); auto app = std::move(result.value()); CHECK(app->poll_events()); const auto id = SDL_GetWindowID(window());