From 3316bf9a8e56735a6180e6c3893353e0652990a3 Mon Sep 17 00:00:00 2001 From: dingo Date: Sun, 11 Oct 2026 04:18:36 -0400 Subject: [PATCH] Fix network test preset and version guard --- CMakePresets.json | 2 +- docs/engineering/VALIDATION.md | 9 +++++++++ tests/network_control.cpp | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/CMakePresets.json b/CMakePresets.json index d7f18f5..bc15cf3 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -23,7 +23,7 @@ {"name": "tsan", "configurePreset": "tsan"}, {"name": "client", "configurePreset": "client", "targets": ["evo-client-state-tests", "evo-client", "evo-client-lifecycle-tests", "evo-client-environment-tests", "evo-client-organism-tests", "evo-client-ui-model-tests", "evo-client-panel-tests", "evo-client-bindings-tests"]}, {"name": "client-probe", "configurePreset": "client-probe", "targets": ["evo-client-probe"]}, - {"name": "network", "configurePreset": "network", "targets": ["evo-client-state-tests", "evo-network-tests", "evo-session-fuzz-smoke", "evo-dev-session"]}, + {"name": "network", "configurePreset": "network", "targets": ["evo-client-state-tests", "evo-network-tests", "evo-cellular-intent-protocol-tests", "evo-cellular-intent-admission-tests", "evo-session-fuzz-smoke", "evo-dev-session"]}, {"name": "quic", "configurePreset": "quic", "targets": ["evo-quic-smoke-tests", "evo-quic-transport-tests", "evo-quic-session-tests", "evo-quic-hol-measure", "evo-session-probe", "evo-load", "evo-network-tests", "evo-session-fuzz-smoke"]}, {"name": "client-network", "configurePreset": "client-network", "targets": ["evo-client-state-tests", "evo-client", "evo-client-lifecycle-tests", "evo-client-environment-tests", "evo-client-organism-tests", "evo-client-ui-model-tests", "evo-client-panel-tests", "evo-client-bindings-tests", "evo-network-tests", "evo-session-fuzz-smoke", "evo-dev-session", "evo-quic-session-tests", "evo-client-remote-tests", "evo-motion-trace", "evo-session-probe"]}, {"name": "client-package", "configurePreset": "client-package", "targets": ["evo-client-state-tests", "evo-client", "evo-client-lifecycle-tests", "evo-client-environment-tests", "evo-client-organism-tests", "evo-client-ui-model-tests", "evo-client-panel-tests", "evo-client-bindings-tests", "evo-network-tests", "evo-session-fuzz-smoke", "evo-dev-session", "evo-quic-session-tests", "evo-client-remote-tests", "evo-motion-trace"]} diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index 1efaf02..97ab148 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -6743,3 +6743,12 @@ Run 249 confirmed the owner dereference fix and rejected the const-array `span` range constructor under GCC 14. The retained build digest is now provided with an explicit data pointer and count. PostgreSQL again stopped at this compile diagnostic before its tests. + +Run 250 built the network source but exposed two test-gate issues: CTest had +registered the cellular protocol and admission suites while the network build +preset omitted their executable targets, and a version-rejection test still +treated protocol 7 as future after protocols 7-9 were added. The preset now +builds both executables and the negative test uses unsupported version 10. +Run 250's network test job failed on the stale expectation; the two omitted +tests were not run because their executables were absent. Follow-up CI is +required to confirm the corrected gate. diff --git a/tests/network_control.cpp b/tests/network_control.cpp index f82df9e..f088f60 100644 --- a/tests/network_control.cpp +++ b/tests/network_control.cpp @@ -371,7 +371,7 @@ void session_codec() { mutated.at(0) ^= 1; CHECK(refused(decode_session(mutated), SessionCodecError::bad_magic)); mutated = bytes; - mutated.at(4) = 7; // A future version. + mutated.at(4) = 10; // A future version; protocol versions through 9 are supported. CHECK(refused(decode_session(mutated), SessionCodecError::unsupported_version)); mutated = bytes; mutated.at(7) = 1;