client: skip used grants; scale the engineering UI with the window
Foundation / checks (deploy) (push) Successful in 3m26s
Foundation / checks (ecs) (push) Successful in 2m2s
Foundation / checks (client) (push) Successful in 12m47s
Foundation / checks (tsan) (push) Canceled after 0s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (network) (push) Canceled after 11m44s
Foundation / checks (checks) (push) Canceled after 17m14s
Foundation / checks (postgres) (push) Canceled after 4m27s

- A stale_grant before Welcome spends only that grant: the session tries the next one
  in the bundle and ends as exhausted when none is left (other refusals still stop).
- UI scale (ADR-0084 amendment): embedded scalable font (ProggyForever), scale from
  logical window height (720 reference, 1.0-2.5) times a Ctrl+= / Ctrl+- nudge; panel
  sizes and table columns in logical units; movable panels placed again per scale.
- --size W,H for engineering review screenshots.
- Tests: client_remote_session (stale grant, exhausted), client_ui_state (scale).
Refresh the dev session window.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
dingo
2026-10-09 12:09:57 -04:00
co-authored by Claude Opus 5.5
parent c468c70933
commit 3320a8a574
11 changed files with 200 additions and 37 deletions
+15
View File
@@ -116,3 +116,18 @@ one frame late for same-batch input. This internal use is tied to the 1.92.9b pi
and must be rechecked on any toolkit update (the lifecycle and panel tests fail if
it regresses). External capture no longer cancels the Tab toggle. Mode and remote
session lifetime are owned together (`SessionHost`).
## Amendment (2026-10-09): scalable font and UI scale
The maintainer asked that the UI grow with the window, after a maximized window left it
at 13 px.
- **Font.** The client now loads Dear ImGui's embedded scalable font, ProggyForever
(`AddFontDefaultVector`), in place of the ProggyClean bitmap font. Both are embedded
in the pinned 1.92.9b sources, and the package's notice inventory already lists
them. No new dependency.
- **UI scale.** Logical window height over 720, clamped to 1.0–2.5, times a user nudge
of 0.5–2.0 in steps of 0.1 (Ctrl+= and Ctrl+-, consumed before world input and not
saved). Display DPI is already in the logical size, through SDL's high-pixel-density
window and the renderer's framebuffer scale.
- **Applying it.** The scale goes to ImGui's `FontScaleMain` and to `ScaleAllSizes`,
taken from the unscaled style. Panel sizes are given in logical units at that scale.
Movable panels return to their default place and size once, at each new scale.
+28
View File
@@ -5325,3 +5325,31 @@ Executed:
- Windows `client` 9/9.
- Windows `client-network` 15/15. This also covers the session-cap change above, whose
`client-network` run had been blocked by the running client.
## 2026-10-09 — engineering client: used grants and UI scale
The maintainer found that their login failures came from a grant that had already been
used. The client had given up on the first `stale_grant`. Now a used grant spends only
itself: the session tries the next grant in the bundle, and a bundle of used grants ends
as exhausted. Other refusals still stop at once. The maintainer also reported that the
UI stayed at 13 px in a maximized window.
ADR-0084 amendment:
- the embedded scalable font;
- a UI scale from window height (720-point reference, 1.0–2.5) times a Ctrl+= / Ctrl+-
nudge;
- panel sizes and table columns in logical units;
- movable panels placed again at each new scale.
`--size W,H` sets the initial window size, for engineering review.
Executed:
- `client_remote_session`: a stale grant moves to the next grant; an all-used bundle
ends as exhausted.
- `client_ui_state`: scale clamps, nudge grid, nonsense inputs.
- Windows `client` 9/9 and `client-network` 15/15.
- Screenshots of the launcher and the fixture at 960×640 and 1920×1080, reviewed: the
scale is 1.5 at 1080, text is crisp, and the inspector labels fit.
Not run: an RDP display-scale check. Under RDP the logical height drives the scale, the
same as on a local display.