Avoid unchecked mutation offer access
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (ecs) (push) Successful in 1m55s
Foundation / checks (postgres) (push) Canceled after 0s
Foundation / checks (tsan) (push) Canceled after 0s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (client) (push) Canceled after 3m38s
Foundation / checks (checks) (push) Canceled after 3m44s
Foundation / checks (network) (push) Canceled after 1m43s

This commit is contained in:
dingo
2026-10-11 07:57:45 -04:00
parent 08ecd14ac4
commit 36eee96d09
3 changed files with 10 additions and 7 deletions
+7 -4
View File
@@ -6829,7 +6829,10 @@ to validate the PostgreSQL migration and remaining jobs.
CI run 271 passed the client, deploy, ECS and network jobs, then the PostgreSQL
image's clang-tidy analysis rejected four unchecked mutation-offer optional
accesses in `cellular_lives.cpp` and `cellular_batch.cpp`. The accesses now use
checked `optional::value()` and the trace matcher checks offer presence before
reading it. The PostgreSQL migration/tests did not run in that job; a fresh CI
run is required to validate the repair and schema v29.
accesses in `cellular_lives.cpp` and `cellular_batch.cpp`. CI run 272 showed
that the analyzer also rejects `.value()` after a preceding presence guard.
Those paths now copy through `value_or()` after the guard, preserving the
existing rejection behavior while avoiding unchecked optional access. Run 272
passed all 68 regular CTests but failed analysis before PostgreSQL
migration/tests; a fresh CI run is required to validate this repair and schema
v29.