diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index 16fa5ac..484551c 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -6894,3 +6894,9 @@ selector includes this cellular lifecycle contract test, so the next push reruns the complete validation and image publish path. The local Bash selector fixture could not start: Windows returned `Bash/Service/CreateInstance/E_ACCESSDENIED`; CI's deploy suite runs that fixture. + +CI run #287 passed client, deploy, ECS and network, then clang-tidy found one more +unchecked nested optional read at `tests/cellular_lives_tests.cpp:289`. The earned +mutation offer is now copied through a safe default after the assertion still +checks the offer has candidates. Its check suite failed, so the dependent server +image did not start; rerun is needed to reach Harbor publication. diff --git a/tests/cellular_lives_tests.cpp b/tests/cellular_lives_tests.cpp index afa4274..f798615 100644 --- a/tests/cellular_lives_tests.cpp +++ b/tests/cellular_lives_tests.cpp @@ -285,8 +285,9 @@ void retained_feeding_earns_a_persistent_mutation_offer() { } CHECK(offered); const auto earned = owner.mutation_offer(life_id); - CHECK(earned && *earned && (*earned)->candidates.size() <= cellular_mutation_candidate_count && - !(*earned)->candidates.empty() && owner.lives()[0].mutation.event_index == 1 && + const auto earned_data = earned.value_or(std::nullopt).value_or(evo::biology::MutationOffer{}); + CHECK(earned && earned_data.candidates.size() <= cellular_mutation_candidate_count && + !earned_data.candidates.empty() && owner.lives()[0].mutation.event_index == 1 && owner.lives()[0].mutation.offer_tick == owner.tick() && total_acquired == threshold + owner.lives()[0].mutation.fed_energy_credit_pj); const auto saved = owner.snapshot();