From 52af3bd0b4e460484b0bcf62b80ace9df4a81c51 Mon Sep 17 00:00:00 2001 From: dingo Date: Sun, 27 Sep 2026 00:55:29 -0400 Subject: [PATCH] Mount writable world proof scratch in TSan CI --- .gitea/workflows/build.yaml | 1 + deploy/README.md | 7 +++++++ docs/engineering/VALIDATION.md | 17 +++++++++++++++++ 3 files changed, 25 insertions(+) diff --git a/.gitea/workflows/build.yaml b/.gitea/workflows/build.yaml index 5d89323..7383201 100644 --- a/.gitea/workflows/build.yaml +++ b/.gitea/workflows/build.yaml @@ -43,6 +43,7 @@ jobs: --security-opt "seccomp=$profile" \ --tmpfs /source/build/tsan/Testing:rw,noexec,nosuid,size=16m,mode=1777 \ --tmpfs /source/build/tsan/cli-integration:rw,noexec,nosuid,size=16m,mode=1777 \ + --tmpfs /source/build/tsan/world-proof:rw,noexec,nosuid,size=16m,mode=1777 \ --tmpfs /tmp:rw,noexec,nosuid,size=16m,mode=1777 "$ci_image" fi diff --git a/deploy/README.md b/deploy/README.md index fc3c477..57cb95f 100644 --- a/deploy/README.md +++ b/deploy/README.md @@ -111,3 +111,10 @@ Moby seccomp profile adds only personality(0x40000). No host security settings change. See ADR-0020 for the source, integrity hash and removal policy. Building the ci-tsan image alone is NOT a TSan test pass; use the workflow's docker run command with the generated profile to execute it locally. + +The TSan run requires writable tmpfs mounts for `build/tsan/Testing`, +`build/tsan/cli-integration` and `build/tsan/world-proof`, plus `/tmp`. Each is +bounded to 16 MiB in the workflow. The world restart test retains generated snapshots, +journals and JSON reports beneath its own random run directory; it cannot create +that directory on the read-only image filesystem. Any new file-producing CTest +must declare its scratch directory in this container invocation as well. diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index 65dcbe7..f5ec3e2 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -1721,3 +1721,20 @@ durability. Rate sources and their interval/residual persistence are not enabled Linux/UBSan, target-host performance, allocator-failure injection and cluster recovery were not executed locally. Existing Linux CTest CI includes the new test. No deployment or World0 operation occurred. Next: M6.3 read-only environment views. + +## TSan world-proof scratch mount correction - 2026-09-27 + +The supplied Linux TSan log failed world-process-restart at CMake MAKE_DIRECTORY, +before launching any proof phase. Its build-local output path had no writable mount +in the read-only test container; Testing and cli-integration already had mounts. +Added the matching 16 MiB, mode-1777, noexec/nosuid tmpfs for +`/source/build/tsan/world-proof`. Container user, rootfs, network, capabilities and +seccomp restrictions are unchanged. Documented all test scratch mounts in deploy/README.md. + +Executed `ctest --test-dir build/release -R '^world-process-restart$' --output-on-failure` +after configuring the Release preset: passed on Windows. `git diff --check` passed. +The workflow mount path was checked against the CMake test's TEST_DIR. No C++ changes +or new sanitizer claims. Local Docker CLI exists, but docker version could not connect +because the dockerDesktopLinuxEngine named pipe is absent. Consequently the corrected +Linux TSan container invocation requires confirmation in Gitea CI; it was not run +locally. No application deployment or World0 changes.