Check the allocator row through a named optional
Foundation / checks (checks) (push) Successful in 40m39s
Foundation / checks (deploy) (push) Successful in 3m54s
Foundation / checks (ecs) (push) Successful in 2m20s
Foundation / checks (network) (push) Successful in 18m45s
Foundation / checks (postgres) (push) Successful in 42m50s
Foundation / checks (tsan) (push) Successful in 9m28s
Foundation / checks (client) (push) Successful in 13m50s
Foundation / server-image (push) Successful in 40s
Foundation / postgres-tools (push) Successful in 1m25s
Foundation / image (push) Successful in 3m20s

clang-tidy's bugprone-unchecked-optional-access could not follow the
optional cell through the indexed row in the provisioner and its test,
failing the PostgreSQL analysis build (run 357). Read the cell through a
checked reference instead. Also refresh the dev session window (3 h).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
dingo
2026-10-13 11:54:33 -04:00
co-authored by Claude Opus 5.5
parent a3939bda4e
commit 56e7525bfb
3 changed files with 13 additions and 7 deletions
+3 -1
View File
@@ -408,7 +408,9 @@ void provisioning_creates_the_life_allocator_once() {
auto db = owner();
auto rows = db->query(
"SELECT next_identity FROM evolution.life_allocators WHERE world_id = 9760", {}, 5s);
return rows && rows->size() == 1 && (*rows)[0][0] ? *(*rows)[0][0] : std::string{};
if (!rows || rows->size() != 1 || (*rows)[0].size() != 1)
return std::string{};
return (*rows)[0][0].value_or(std::string{});
};
int code = -1;
const auto development = run("development-v1", 5000, code);