Keep every captured key owned until its own release
Binding capture tracked one owned key, so a second capture could overwrite an unreleased earlier choice and leak its repeats. Ownership is now a bitset over scancodes, released per key or on focus loss, with successive-capture, release order, cancel and focus-loss regressions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -72,3 +72,8 @@ is suppressed while it is held). The adapter runs an idle toolkit frame when not
|
||||
is drawn and bounds the toolkit input queue at 512 events (dropped with every
|
||||
toolkit key/button released). The Controls host logic lives in
|
||||
`apps/evo-client/controls_flow.hpp` and is rehearsed with the real adapter.
|
||||
|
||||
Follow-up: ownership is a set (one bit per SDL scancode), not a single key. Each
|
||||
chosen key is released only by its own key-up or by focus loss; a later capture,
|
||||
or cancelling it, never transfers or drops earlier ownership; text stays
|
||||
suppressed while any owned key is held.
|
||||
|
||||
@@ -85,7 +85,8 @@ the keys in force. `client-panels` checks the panel geometry and that a slot cli
|
||||
requests capture without a world click.
|
||||
|
||||
Capture and toolkit (M9.8d review): arming binding capture clears the toolkit's held
|
||||
keys/modifiers and its queued keyboard/text input; the chosen key is consumed until
|
||||
released (repeats, text, release), and focus loss frees it. With no overlay or a
|
||||
keys/modifiers and its queued keyboard/text input; every chosen key is consumed
|
||||
until its own release (repeats, text, release), across successive captures; focus
|
||||
loss frees them all. With no overlay or a
|
||||
paused window the adapter still runs idle toolkit frames; more than 512 queued
|
||||
toolkit events are dropped with all toolkit keys/buttons released.
|
||||
|
||||
@@ -3831,3 +3831,22 @@ repository format check.
|
||||
|
||||
Limits: physical keyboards, non-US layouts and IME remain unqualified; the Apply
|
||||
rehearsal is automated with synthetic events, not a manual session.
|
||||
|
||||
|
||||
## 2026-10-02 — M9.8d follow-up (.cache/reviews/m98d-followup-review.md)
|
||||
|
||||
Owned capture keys are now a bounded set (bitset over SDL scancodes) instead of one
|
||||
optional key, so a second capture cannot overwrite an unreleased earlier choice.
|
||||
Lifecycle regressions in `capture_balances_toolkit`: W then K chosen with K released
|
||||
first (W repeat/text reach neither toolkit nor world until W's release, then a
|
||||
fresh W moves and reaches the toolkit); reverse release order (K stays owned after
|
||||
J's release; text flows again only when nothing is owned); cancel during a second
|
||||
capture keeps the first key owned; focus loss frees both; positive controls after
|
||||
each. Negative check: restoring single-key ownership fails the W repeat check.
|
||||
|
||||
Executed: Windows MSVC client 9/9 and client-network 10/10 (final, after
|
||||
formatting). Linux: clang-19 client-probe with clang-tidy (keep-going, no owned
|
||||
diagnostics) CTest 13/13; Xvfb lifecycle and panels; Clang ASan/UBSan CTest 13/13
|
||||
plus Xvfb lifecycle/panels; GCC 14 client-network CTest 10/10; clang-tidy app
|
||||
main/panels; format check. Synthetic event sequences only: physical OS repeat with
|
||||
several held keys, non-US layouts and IME remain unqualified.
|
||||
|
||||
Reference in New Issue
Block a user