From 6219e0acb455bfaead911e328af4294132727395 Mon Sep 17 00:00:00 2001 From: dingo Date: Mon, 28 Sep 2026 09:03:38 -0400 Subject: [PATCH] Fix CI: widening-cast lint errors and Postgres C compiler - tests/environmental_qualification.cpp: widen operands before multiplying to satisfy bugprone-misplaced-widening-cast. - Dockerfile: build Postgres with CC=gcc-14; the toolchain image has only versioned compilers, so configure found no cc/gcc. Not validated locally (no clang-format/clang-tidy/Docker run here); relies on the CI checks and postgres suites. Co-Authored-By: Claude Opus 5.5 --- deploy/docker/Dockerfile | 3 ++- tests/environmental_qualification.cpp | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/deploy/docker/Dockerfile b/deploy/docker/Dockerfile index 041ceb8..69caa93 100644 --- a/deploy/docker/Dockerfile +++ b/deploy/docker/Dockerfile @@ -50,7 +50,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ curl bzip2 make flex bison libssl-dev zlib1g-dev pkg-config \ && rm -rf /var/lib/apt/lists/* COPY migrations/ migrations/ -RUN bash tools/prepare-postgres.sh +# The toolchain installs versioned compilers only; there is no bare cc/gcc. +RUN CC=gcc-14 bash tools/prepare-postgres.sh RUN cmake --preset release -B build/postgres -DCMAKE_CXX_COMPILER=g++-14 \ -DEVO_BUILD_POSTGRES=ON -DPostgreSQL_ROOT=/source/.cache/postgres/install \ && cmake --build build/postgres --target evo-postgres-tests --parallel 2 diff --git a/tests/environmental_qualification.cpp b/tests/environmental_qualification.cpp index d35eba4..6f9c769 100644 --- a/tests/environmental_qualification.cpp +++ b/tests/environmental_qualification.cpp @@ -396,7 +396,8 @@ void sequences(std::uint64_t ticks) { std::chrono::duration(std::chrono::steady_clock::now() - start).count(); std::printf("seeds=16 ticks_per_seed=%llu paired_steps=%llu captured=%llu grown=%llu " "bites=%llu fingerprint=%016llx validation_seconds=%.6f\n", - static_cast(ticks), static_cast(32 * ticks), + static_cast(ticks), + 32ULL * static_cast(ticks), static_cast(capture), static_cast(growth), static_cast(bites), static_cast(fingerprint), elapsed); @@ -527,8 +528,8 @@ void integrated(std::uint64_t episodes) { std::printf( "slice regime=%u episodes=%llu ticks=%llu capture=%llu growth=%llu " "assimilated_N=%llu returned_N=%llu regrowth=%llu hash=%016llx\n", - regime, static_cast(16 * episodes), - static_cast(16 * episodes * 128), + regime, 16ULL * static_cast(episodes), + 16ULL * 128ULL * static_cast(episodes), static_cast(captured), static_cast(grown), static_cast(assimilated_n), static_cast(returned_n), static_cast(regrown),