From 715b7bcd97bf3d7092b165f0eca661df0c66fa50 Mon Sep 17 00:00:00 2001 From: dingo Date: Sun, 11 Oct 2026 03:24:02 -0400 Subject: [PATCH] Initialize optional input on legacy actions --- docs/engineering/VALIDATION.md | 6 ++++++ src/network/protocol/intent_admission.cpp | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index bc3d59b..add4218 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -6714,3 +6714,9 @@ in `ActionLedger::find_record`. The function now moves the inner optional to a local, checks its state, and unwraps only after that check. This is an existing network-ledger warning exposed by the full network target; full CI is pending for the combined repairs. + +Run 245 confirms that optional-access fix removes its clang-tidy failure, then +reports two `-Wmissing-field-initializers` errors for legacy probe actions after +`CarriedAction` gained its optional cellular input. Those probe records now set +that input to `std::nullopt` explicitly; run 245 stopped before network tests. +The combined repairs are queued for a new full CI run. diff --git a/src/network/protocol/intent_admission.cpp b/src/network/protocol/intent_admission.cpp index 46e8f9c..5c38d33 100644 --- a/src/network/protocol/intent_admission.cpp +++ b/src/network/protocol/intent_admission.cpp @@ -230,7 +230,7 @@ ActionReceipt IntentAdmission::action(std::uint64_t session, const SessionAction decide(s->account, r, lookup(s->account, m.action_id)); if (r.status == AdmitStatus::admitted) actions_.push_back( - {{s->account, m.action_id, m.tick, ActionKind::probe}, Stage::scheduled}); + {{s->account, m.action_id, m.tick, ActionKind::probe, std::nullopt}, Stage::scheduled}); return r; } @@ -264,7 +264,7 @@ std::optional IntentAdmission::admit(std::uint64_t session, const return r; // Held like an admitted action (duplicates and the unresolved limit see it), but never // carried until `verify` confirms it. - actions_.push_back({{s->account, m.action_id, m.tick, ActionKind::probe}, + actions_.push_back({{s->account, m.action_id, m.tick, ActionKind::probe, std::nullopt}, check ? Stage::verifying : Stage::scheduled, false, session,