Stop calling the end of watching a death

Three defects from review of 89ad95b.

An organism still alive when an episode stopped was recorded dead. A one-tick
run reported no extinctions while writing terminal records for founders that had
not died, and their watched time was added to the same total as completed
lifetimes. Observation ending is a fact about the run, not about the organism,
and ADR-0034 makes a recorded death terminal, so there was nothing to be
terminal about. Survivors stay living now and are counted apart, with their
watched time as the lower bound it is; lived_ticks and observed_ticks answer
different questions and are never summed together.

A genome without the reproduction capability derives a zero investment, which
the driver refused outright, so seeds 10, 12 and 15 failed the whole run.
Filtering those variants out before sampling would have been the worse repair:
the measured set would then be the fertile subset a guard approved of, and being
unable to reproduce is a result rather than grounds for exclusion. The driver
runs such a strategy and proposes no birth for it. ADR-0029 is amended rather
than quietly contradicted.

A half's thermal shortfall was assigned where it was documented as a total, so
two episodes at 15,000 reported 15,000.

Only configurations the driver already rejected behave differently, so the M2.6
pin 2cd4a15f9fbe9949 was checked rather than assumed and still holds. The
ensemble pin moved because the reported facts changed, not to pass a test; the
reason sits beside it. Each fix was confirmed load-bearing by reverting it alone.

Release 33/33, analysis, ASan 33/33 and clang-format all ran and passed here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
dingo
2026-09-24 05:58:22 -04:00
co-authored by Claude Opus 5
parent 89ad95bf12
commit 72ed03f4dd
12 changed files with 316 additions and 34 deletions
+64
View File
@@ -796,3 +796,67 @@ names, so a rejection arriving from a different branch would still pass. Golden
frozen genome fixture are unchanged, and ADR-0029's episode driver was not
touched. No deployment manifest or image pin changed. Linux validation is pending;
no Gitea result is claimed since `b01a824`.
Review of `89ad95b` found three defects (2026-09-24), each now fixed with a
regression confirmed to fail against the unfixed code.
The harness recorded a death for every organism still alive when an episode
stopped. A one-tick run therefore reported zero extinctions while writing terminal
death records for founders that had not died, and every such organism's watched
time was added to the same total as a completed lifetime. Ending observation is
not death, and ADR-0034 makes a recorded death terminal, so there was nothing for
the archive to be terminal about. Survivors now stay living, are counted in
`survivors`, and their watched time accumulates in `observed_ticks`, which is a
lower bound on a lifetime the run never saw end. `deaths` and `lived_ticks` cover
only organisms observed to die, and the two are never added together. The run and
archive test now checks that deaths plus survivors equals every organism recorded
and that a lineage is absent exactly when all its carriers were seen to die.
A draw that produced a genome without the reproduction capability derived a zero
reproduction investment, which ADR-0029's driver refused outright, so
`--ensemble --seed 10` exited with invalid_arguments; seeds 12 and 15 were
confirmed to fail the same way and seed 11 to succeed. Filtering such variants out
before sampling was rejected as the worse repair: the measured set would then have
been the fertile subset chosen by a guard, and an inability to reproduce is a
result rather than a reason for exclusion. The driver now accepts the strategy and
proposes no birth for it, since an empty investment would otherwise clear both
reproduction bounds trivially and request a birth transferring nothing. ADR-0029
is amended rather than silently contradicted, and ADR-0035's claim that the driver
does not change was corrected to say what did.
Only configurations the driver previously rejected outright behave differently, so
the M2.6 pin was expected to hold and was checked rather than assumed:
`--ecosystem --seed 0 --episodes 32` still reports `2cd4a15f9fbe9949`, and the
ecosystem, feeding and producer suites pass unchanged. The ecosystem test that
asserted a zero investment is rejected now asserts the opposite fact, that such an
episode runs and reports no births.
A half's thermal shortfall was assigned rather than accumulated, so a field
documented as a total across the half's episodes carried one episode's reading.
Two episodes at 15,000 millikelvin reported 15,000 rather than 30,000. It now
accumulates per episode. The tolerance test's expectations were per-episode
readings and are now stated against the episode count, with an assertion that the
count exceeds one so a sum and a single reading cannot look alike.
`cli-ensemble` was repinned from `c2b96c86101be628` to `5ec59d390909b526`,
confirmed stable across three runs and distinct from seed 7's `090b83efb85ae477`.
This is a change in reported facts, not a test accommodation: survivors are no
longer counted as deaths, the outcome record gained `deaths`, `survivors` and
`observed_ticks`, and the shortfall is now a sum, so the previous value describes
a report this build does not produce. The rationale is recorded beside the pin.
Each fix was confirmed to be load-bearing by reverting it alone and rebuilding.
Restoring the survivor-as-death behaviour failed the archive test at the survivor
count and, when that test was run second, the dedicated regression at `deaths ==
0`. Restoring the zero-investment rejection failed the sterile-strategy regression
at `EcosystemEpisode::create`. Restoring the assignment of thermal shortfall
failed the summation regression. One of my own expectations was wrong rather than
the code: a one-tick episode's survivors include organisms born during that tick,
watched for none of it, so observed time equals one tick per founder rather than
one per survivor. The test now says that.
Coverage limits unchanged from the increment above, with two additions. Censored
lifetimes mean a run's mean lifetime is not computable from `lived_ticks` alone
and no test asserts one. Across a run the archive now ends holding living
carriers, which is accurate about what was observed and is not a claim that
anything persists; nothing is serialized.