Check rendered kustomize output in the deploy policy (M9.8f review)

The policy check now renders every overlay with pinned, checksum-verified
kustomize v5.8.1 (ADR-0088) and validates effective namespaces, session/input/
listener environment and arguments, ports, Services, quotas, policies, Ingresses
and Secrets, so inline/JSON patches and namespace changes cannot bypass it.
Route enabling is gated on an ADR-0087 amendment with tested server windows, route
addresses must be RFC 1918 or explicitly approved, and the Local health-check node
port is documented with its enabling evidence. Self-test grows to 33 cases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
dingo
2026-10-02 18:02:57 -04:00
co-authored by Claude Opus 5.5
parent 9f622cf6b3
commit 8a1e5ef53d
12 changed files with 386 additions and 32 deletions
+4 -3
View File
@@ -4,9 +4,10 @@ Status: M9.8a probe, M9.8b owned state/capture/event bounds, M9.8c launcher,
legend, labelled inspector and click selection, and M9.8d rebindable controls
complete, 2026-10-02. M9.8e local Windows ZIP complete (ADR-0086); its Gitea
Actions publication waits for a Windows runner and its clean-VM run for M9.8g.
M9.8f route design, disabled manifests and fail-closed policy tests complete
(ADR-0087); enabling waits for the VIP, client CIDR, DNS, dev quota and server-enforced
session windows. M9.8g remains.
M9.8f design, disabled manifests and rendered fail-closed policy checks delivered
(ADR-0087, ADR-0088); the M9.8f gate stays open until the route is enabled (VIP, client
CIDR, DNS, dev quota, health-check port evidence and server-enforced session windows)
and connectivity is recorded. M9.8g remains.
No application UI or deployment completion is claimed. See ADR-0084 for the toolkit boundary.
## Confirmed scope
+32
View File
@@ -3930,3 +3930,35 @@ were run directly), any cluster/server dry-run, MetalLB allocation, DNS, firewal
connectivity. Server-enforced session windows and the Gitea window workflow are not
implemented; Argo delivery for windows and the existing void HTTP Ingress are open
maintainer decisions recorded in ADR-0087.
## 2026-10-02 — M9.8f review corrections (.cache/reviews/M9.8f-9f622cf-review.md)
P1 (rendered configuration): the policy check now renders all 17 non-component
kustomizations with pinned kustomize v5.8.1 (ADR-0088; official archive, SHA-256
029a7f0f…a819d checked against the release checksums) and validates the effective
objects: overlay namespaces, evo-region session/input/listener environment, a single
listener argument, container ports, Service types and session port, route shape, session
NetworkPolicies, quotas, Ingresses and no Secrets. Unsupported kustomize features
(plugin generators/transformers, Helm, Secret generators) are refused. Route enabling is
gated by `ROUTE_ENABLING_PERMITTED = False`, changed only with an ADR-0087 amendment
recording the implemented window contract and runtime expiry tests; the earlier
`--session-window` string test is gone. Route addresses must be RFC 1918 or listed in
`APPROVED_INTERNAL` (empty; 172.10.1.x is not RFC 1918).
P2 (health-check port): manifest comment and ADR-0087 now state that the Local policy
allocates `healthCheckNodePort`; allocation, quota accounting and firewall handling are
enabling preconditions. Review recommendations (manual Argo sync, preserving the void
endpoint, address confirmation, window limits and tests) are recorded in ADR-0087 as
pending maintainer decisions. The M9.8f gate stays open.
Executed (WSL Ubuntu, Python 3, PyYAML 6.0.1, kustomize v5.8.1 via the new prepare
script, idempotent on rerun): policy check 70 source objects / 126 rendered objects in
17 overlays, 0 failures; self-test 33/33 refused (20 earlier cases plus non-RFC 1918 VIP,
the reviewer's combined inline patches, inline listener/session/input patches, JSON
patches adding a session port, a LoadBalancer, a container port and a second listener
argument, namespace transformation, inline stage quota, Secret generator, Helm inflation);
the reviewer's m98f-policy-repro.py now exits 1 with the listener, session/input and
ops-port failures in both region/dev and dev; the check fails without kustomize and with
kustomize v5.4.3; ops-lib and ci-path fixtures pass.
Not run: the ci-deploy Docker stage (no Docker here; its commands were run directly,
including prepare-kustomize.sh), any cluster dry-run or live action.