Fix optional access in reservation tests
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 6s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 1m58s
Foundation / checks (tsan) (push) Successful in 8m4s
Foundation / checks (postgres) (push) Failing after 21m34s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 24m49s

This commit is contained in:
dingo
2026-10-10 16:28:27 -04:00
parent be1177cc03
commit 94edeba474
2 changed files with 18 additions and 5 deletions
+8
View File
@@ -5706,3 +5706,11 @@ explicitly checked before access. clang-format 19.1.5 dry-run, clang-tidy 19.1.5
with warnings-as-errors, GCC 13.2 Release/NDEBUG compilation with warnings-as-
errors, and `git diff --check` pass locally. PostgreSQL integration remains
unavailable in this Windows environment; awaiting CI rerun.
The next CI analysis build reached the PostgreSQL tests and reported four
`bugprone-unchecked-optional-access` errors in the life-reservation test's nested
`expected<optional<...>>` checks. Reworked those assertions to extract safe
fallback values while still checking both success/presence states. clang-format
19.1.5, clang-tidy 19.1.5 with warnings-as-errors, GCC 13.2 Release/NDEBUG
compilation with warnings-as-errors, and `git diff --check` pass locally. The
PostgreSQL test binary remains unrun locally; awaiting CI rerun.