fix(cellular): one action per account a tick, never a refused tick
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (checks) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 4s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (postgres) (push) Successful in 4s
Foundation / checks (tsan) (push) Successful in 4s
Foundation / postgres-tools (push) Successful in 1m39s
Foundation / server-image (push) Successful in 5m19s
Foundation / image (push) Successful in 6m54s
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (checks) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 4s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (postgres) (push) Successful in 4s
Foundation / checks (tsan) (push) Successful in 4s
Foundation / postgres-tools (push) Successful in 1m39s
Foundation / server-image (push) Successful in 5m19s
Foundation / image (push) Successful in 6m54s
Region 16 playtest: a bud showed and was then undone, and several buds were
refused. The client scheduled a discrete action at server tick + lead, but
movement runs ahead of that once the lead shrinks (each movement takes the
tick after the last one sent), so a bud could name a tick a movement already
had. A tick takes one action per account: the region refused the whole tick
and dropped every player's actions on it ("tick stalled ... error=4").
- Server: keep_one_action_per_account keeps each account's discrete action
(engulf, bud, become, emerge), else its newest, and refuses only the rest.
- Client: a discrete action is scheduled after every tick already sent, and
movement is held off the tick a queued discrete action owns.
- Failed background commits now log their category, publication error,
store error and SQLSTATE (never server text), to diagnose ok=0 commits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -47,6 +47,13 @@ prepare_cellular_session_tick(
|
||||
std::span<const network::CarriedAction> actions,
|
||||
std::span<const persistence::CellularMutationReservation> mutations = {});
|
||||
|
||||
// A tick takes one action per account. Keeps each account's discrete action (engulf, bud,
|
||||
// become, emerge), else its newest (highest id), in `actions`, and returns the others, which
|
||||
// the caller refuses. A client naming a tick it already sent a movement for then loses only
|
||||
// that movement, not every player's actions on the tick.
|
||||
[[nodiscard]] std::vector<network::CarriedAction>
|
||||
keep_one_action_per_account(std::vector<network::CarriedAction>& actions);
|
||||
|
||||
// Builds one bounded publication from the last durable head. Its working copy is private;
|
||||
// only the host may publish, and callers must discard it after uncertainty until the host
|
||||
// resolves that exact prepared batch.
|
||||
|
||||
Reference in New Issue
Block a user