From a23d45f7dfbab64df3c94478f429643e86059998 Mon Sep 17 00:00:00 2001 From: dingo Date: Sun, 11 Oct 2026 18:09:13 -0400 Subject: [PATCH] Reject empty clone provisioning sites --- apps/evo-world-clone/main.cpp | 2 ++ docs/engineering/VALIDATION.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/apps/evo-world-clone/main.cpp b/apps/evo-world-clone/main.cpp index 1da0b91..f6bc04c 100644 --- a/apps/evo-world-clone/main.cpp +++ b/apps/evo-world-clone/main.cpp @@ -116,6 +116,8 @@ std::optional number(std::string_view text) { return value; } std::optional site(std::string_view text) { + if (text.empty()) + return std::nullopt; const auto comma = text.find(','); if (comma == std::string_view::npos || text.find(',', comma + 1) != std::string_view::npos) return std::nullopt; diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index 87840b1..243d417 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -7008,3 +7008,5 @@ CI run #302 compiled that cellular change, then PostgreSQL clang-tidy found thre CI run #303 stopped at the format gate on the SQLSTATE expression from the preceding fix, before reaching clang-tidy. The continuation is now laid out for clang-format; local clang-format is unavailable, so CI must verify formatting along with the analysis and Harbor publish gates. CI run #304 rejected both wrapped layouts of the SQLSTATE expression at the formatting gate. The complete statement is now joined onto one line (within the configured 100-column limit); CI must confirm the exact formatter output. + +CI run #305 passed formatting and most independent gates, but PostgreSQL clang-tidy rejected `site()` in `apps/evo-world-clone/main.cpp`: `string_view::data()` may be null for an empty view passed to `from_chars`. The parser now rejects an empty site argument before accessing its data. The dependent PostgreSQL tools and server-image/Harbor publication jobs did not run; CI must validate the guard and complete publication.