Fix M9.8c review findings in the engineering client

Resolve pointer ownership per SDL event so same-batch panel clicks, wheel and
click-to-focus typing never reach the world; keep the Tab toggle independent of
idempotent external capture release; own launcher phase and remote session
together so Local fixture ends any remote attempt; wrap notices beside a
reserved close column within a bounded stack. Adds client-panels test and
host/session, same-batch and host-order Tab regressions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
dingo
2026-10-02 11:10:32 -04:00
co-authored by Claude Opus 5.5
parent 897055883a
commit bb8c2fc359
15 changed files with 571 additions and 55 deletions
+41
View File
@@ -3715,3 +3715,44 @@ screen reader or accessibility review; the remote review used one connect withou
WASD intentions, so the outcome list was empty in the screenshot (outcome states are
covered by unit tests). No Docker/Gitea run, packaging, deployment or cluster test.
No simulation version, wire format or golden changed.
## 2026-10-02 — M9.8c review corrections (.cache/reviews/m98c-review.md)
1. Same-batch panel input: pointer ownership is now resolved per SDL event from the
toolkit's retained window rectangles/popup stack (pinned internal API, ADR-0084);
a press on a panel owns the button until release and drops world key-downs for
the rest of that batch. Regressions without settling frames: world->panel move +
press/release (no world click, button still activates), move + wheel (no zoom;
world wheel still zooms), click-to-focus + W in one batch (no movement; field
captures; fresh press after unfocus moves).
2. Fixture/live distinction: `SessionHost` owns launcher phase and remote session;
fixture, cancel, disconnect and failure drop the session; it is serviced only
while connecting/connected. `client-ui-model` uses a fake session/server:
connecting->fixture and failed->fixture followed by an available server produce
no steps, Welcome (grant use) or intentions; ordinary connect still works.
3. Tab capture: an external release no longer cancels it. Regression drives the
host order (poll, set_ui_capture(false), sample, present) over several frames,
requires capture until the second toggle and a fresh, non-repeat press after.
4. Notices: wrapped text beside a reserved 22-pixel close column, width min(320,
viewport-16), stack bounded to 60 % of the height with a not-shown/discarded
count. New `client-panels` renders the production panels through the adapter:
the three real session notices and a 240-byte message fit (content width and no
horizontal scroll), the close button clicked in one batch dismisses exactly that
notice with no world click; a full stack stays on screen.
Negative checks: the new lifecycle test fails against the previous adapter (same-
batch click), the panel test against the previous notice layout (content width),
and the host-order Tab test with the former clearing restored (Windows MSVC).
A GCC-only failure in the new fake-session test was a test bug (by-value argument
alive until the full expression ends); split the assertion.
Executed: Windows MSVC client 8/8 and client-network 9/9 (final). Linux: clang-19
client-probe build with clang-tidy enabled (keep-going, no owned diagnostics) and
CTest 12/12; Xvfb/X11 lifecycle and panel tests; Clang ASan/UBSan client CTest 12/12
and Xvfb lifecycle/panels; GCC 14 client-network build, client|network CTest 9/9;
clang-tidy on app main/panels (client-network); repository format check. Visual:
live WSL dev region showing the wrapped connection notice with its close button.
Limits unchanged: no physical mouse/keyboard session, DPI or accessibility review;
the live screenshot sent no intentions. No Docker/Gitea, packaging or deployment.