Fix primitive host clang-tidy findings
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (ecs) (push) Successful in 1m55s
Foundation / checks (client) (push) Successful in 12m16s
Foundation / checks (network) (push) Successful in 13m43s
Foundation / checks (tsan) (push) Successful in 8m11s
Foundation / checks (postgres) (push) Failing after 20m58s
Foundation / checks (checks) (push) Successful in 33m53s
Foundation / postgres-tools (push) Skipped
Foundation / server-image (push) Skipped
Foundation / image (push) Skipped

This commit is contained in:
dingo
2026-10-10 15:53:21 -04:00
parent 67f3545d5b
commit be1177cc03
2 changed files with 43 additions and 21 deletions
+8
View File
@@ -5698,3 +5698,11 @@ the `performance-move-const-arg` clang-tidy warning on the v17 outcome adapter.
Both were corrected. clang-format 19.1.5 dry-run and clang-tidy 19.1.5 on
`region_lease_store.cpp` pass locally. Awaiting CI rerun for the database,
migration, host test and repository checks; no local runtime pass is claimed.
The subsequent CI build found one more `performance-move-const-arg` and eight
`bugprone-unchecked-optional-access` errors in `primitive_region_host.cpp`.
Removed the ineffective move and made lease grants and nested optional values
explicitly checked before access. clang-format 19.1.5 dry-run, clang-tidy 19.1.5
with warnings-as-errors, GCC 13.2 Release/NDEBUG compilation with warnings-as-
errors, and `git diff --check` pass locally. PostgreSQL integration remains
unavailable in this Windows environment; awaiting CI rerun.