Check effective NetworkPolicy ingress to the region session port

Rendered policies must keep default-deny in every environment, and no ingress rule
that can select a region pod may admit the session port (no or empty ports, the
session name, 7400 or a spanning range) except the validated route policy. Route
Service and policy validators are shared by source and rendered checks. Self-test
grows to 44 cases, including the reviewer's all-ingress reproduction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
dingo
2026-10-02 19:06:49 -04:00
co-authored by Claude Opus 5.5
parent 8a1e5ef53d
commit cb31893a47
4 changed files with 201 additions and 53 deletions
+20
View File
@@ -3962,3 +3962,23 @@ ops-port failures in both region/dev and dev; the check fails without kustomize
kustomize v5.4.3; ops-lib and ci-path fixtures pass.
Not run: the ci-deploy Docker stage (no Docker here; its commands were run directly,
including prepare-kustomize.sh), any cluster dry-run or live action.
## 2026-10-02 — M9.8f review of 8a1e5ef (.cache/reviews/M9.8f-8a1e5ef-review.md)
P2: rendered NetworkPolicies are now checked by effect: the default-deny contract in
every environment namespace, and every ingress rule able to select a region pod
(empty/expression selectors included) is refused if it admits the session port (no or
empty ports, port-less TCP entries, the `session` name, 7400, ranges spanning it), except
the fully validated route policy. Activation follow-up done now: the route Service and
policy validators (VIP, source ranges, annotations, selector, shape) are shared by the
source and rendered checks.
Executed (WSL, kustomize v5.8.1): policy check 0 failures (126 rendered objects, existing
ops/metrics scrape rule accepted); self-test 44/44 refused, adding the reviewer's
all-ingress default-deny patch, region policies without ports, with empty ports, by
the session name, by a 7000-8000 range, an every-pod policy on 7400, an expression
selector, a port-less entry, and rendered route patches of the selector, VIP and source
range; the reviewer's m98f-8a1e5ef-repro.py now exits 1 with default-deny and
session-port failures in platform/dev and platform/cluster. No cluster action. M9.8f
remains open.