From e2eba895b5230393ebd60802d9369622744ea61e Mon Sep 17 00:00:00 2001 From: dingo Date: Sun, 11 Oct 2026 16:18:17 -0400 Subject: [PATCH] Fix clone provision option parsing --- apps/evo-world-clone/main.cpp | 14 +++++++------- docs/engineering/VALIDATION.md | 8 ++++++++ 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/apps/evo-world-clone/main.cpp b/apps/evo-world-clone/main.cpp index 4c426fa..97447c0 100644 --- a/apps/evo-world-clone/main.cpp +++ b/apps/evo-world-clone/main.cpp @@ -267,19 +267,19 @@ std::optional parse(int argc, char** argv) { (value == "development-v1" || value == "primitive-v1" || value == "cellular-v1")) o.opening = value; else if (o.command == "provision" && flag == "--frame" && n) - o.primitive_frame = *n; + o.primitive_frame = n; else if (o.command == "provision" && flag == "--source-id" && n) - o.primitive_source = *n; + o.primitive_source = n; else if (o.command == "provision" && flag == "--funding-energy-pj" && n) - o.primitive_funding[0] = *n; + o.primitive_funding[0] = n; else if (o.command == "provision" && flag == "--funding-carbon-fg" && n) - o.primitive_funding[1] = *n; + o.primitive_funding[1] = n; else if (o.command == "provision" && flag == "--funding-nitrogen-fg" && n) - o.primitive_funding[2] = *n; + o.primitive_funding[2] = n; else if (o.command == "provision" && flag == "--funding-phosphorus-fg" && n) - o.primitive_funding[3] = *n; + o.primitive_funding[3] = n; else if (o.command == "provision" && flag == "--funding-other-fg" && n) - o.primitive_funding[4] = *n; + o.primitive_funding[4] = n; else if (o.command == "provision" && flag == "--site") { const auto parsed = site(value); if (!parsed || o.primitive_sites.size() == server::max_primitive_lives) diff --git a/docs/engineering/VALIDATION.md b/docs/engineering/VALIDATION.md index 3b2d891..c54b913 100644 --- a/docs/engineering/VALIDATION.md +++ b/docs/engineering/VALIDATION.md @@ -6970,3 +6970,11 @@ follows the repository formatter output; local `clang-format --dry-run --Werror` and `git diff --check` pass. The PostgreSQL matrix job continued independently, but its result cannot unblock image publication. Run #298 must rerun the full matrix and server image/Harbor gates. + +CI run #298 passed the main build/test job and network suite, then the +PostgreSQL-enabled Clang analysis rejected the provision CLI's assignments from +`*n` into optional fields at `apps/evo-world-clone/main.cpp:270-282` with +`bugprone-optional-value-conversion`. The validated parser value is itself an +optional, so these destinations now copy `n` directly. PostgreSQL analysis +failed before the dependent server-image build and Harbor publication could +start; the next pushed run must confirm the analyzer and image publish gates.