Tick cellular births only for accounts holding a session
Foundation / checks (ecs) (push) Successful in 2m19s
Foundation / checks (deploy) (push) Successful in 3m56s
Foundation / checks (tsan) (push) Successful in 9m34s
Foundation / checks (client) (push) Successful in 16m45s
Foundation / checks (network) (push) Successful in 18m57s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 28m43s
Foundation / checks (postgres) (push) Canceled after 28m44s
Foundation / checks (ecs) (push) Successful in 2m19s
Foundation / checks (deploy) (push) Successful in 3m56s
Foundation / checks (tsan) (push) Successful in 9m34s
Foundation / checks (client) (push) Successful in 16m45s
Foundation / checks (network) (push) Successful in 18m57s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 28m43s
Foundation / checks (postgres) (push) Canceled after 28m44s
A second account's queued birth outlived its session. Every following batch failed check_life_control with EVL02, which the host reads as a lost region lease, so region 100/3 fenced, reacquired and failed again every 20 s, refusing logins. Include, and tick for, only births whose account holds a session; the rest stay queued until the account returns. Record the incident in ADR-0123. Also refresh the dev session window (3 h). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1021,7 +1021,19 @@ int serve_cellular(Options& o) {
|
||||
}
|
||||
}
|
||||
}
|
||||
const bool birth_waiting = !host.queued_births().empty();
|
||||
// A queued birth publishes only while its account holds a session here: the
|
||||
// publisher checks current account control, and a departed account's birth would
|
||||
// fail every batch with the lease-fence code, so the region would fence itself in a
|
||||
// loop. The birth stays queued and resumes when the account returns.
|
||||
std::vector<server::CellularTickIntents::Birth> held_births;
|
||||
for (const auto& birth : host.queued_births()) {
|
||||
network::AccountId account;
|
||||
account.bytes = birth.account;
|
||||
if (held_births.size() < biology::max_cellular_tick_lives &&
|
||||
bridge->sessions().holder(account))
|
||||
held_births.push_back(birth);
|
||||
}
|
||||
const bool birth_waiting = !held_births.empty();
|
||||
if (status.ready && state && (player_present || birth_waiting)) {
|
||||
const auto now = std::chrono::steady_clock::now();
|
||||
if (!next_tick)
|
||||
@@ -1039,9 +1051,7 @@ int serve_cellular(Options& o) {
|
||||
if (!builder) {
|
||||
bridge->dropped(actions, true);
|
||||
} else {
|
||||
const auto births = host.queued_births().first(
|
||||
std::min(host.queued_births().size(), biology::max_cellular_tick_lives));
|
||||
const auto appended = builder->append(tick, baseline, actions, births);
|
||||
const auto appended = builder->append(tick, baseline, actions, held_births);
|
||||
if (!appended) {
|
||||
bridge->dropped(actions, true);
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user