Stop the availability bound wrapping to zero
The helper summing available material added four unrestricted u64 channels without a check. With 2^62 in each, the sum reaches exactly 2^64 and wraps to zero, so the bound read as no material at all and both planning and budgeting refused growth that a billion femtograms per channel funds. The sum now saturates. That is also the right answer rather than merely a safe one: no step can need more than u64 femtograms, so a saturated bound is correctly permissive. Regressions in both suites use the exact 2^62 case and a single saturated channel, and require the step that an ordinary supply funds. Both were confirmed to fail without saturation. The equivalent helper in metabolism.cpp is applied only to inventories derived from bounded phenotype masses, never to caller input, so it is left alone rather than given a branch no test could reach. That is recorded in the validation report. Native Release, clang-tidy analysis, ASan and format checks pass 19/19. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -553,6 +553,17 @@ checked to fit the availability channel by channel and never to exceed the step
|
||||
the plan proposed. These tests were confirmed to fail with the per-channel check
|
||||
removed.
|
||||
|
||||
A third review found the availability bound itself could wrap: summing four
|
||||
unrestricted u64 channels with 2^62 in each reaches exactly 2^64, so the total
|
||||
read as zero and both planning and budgeting refused growth that a billion
|
||||
femtograms per channel funded. The sum now saturates, which is also the right
|
||||
answer since no step can need more than u64. Regressions in both suites use that
|
||||
exact 2^62 case and a single saturated channel, and require the same step a
|
||||
billion per channel funds; both were confirmed to fail without saturation. The
|
||||
equivalent helper in `metabolism.cpp` is applied only to inventories derived from
|
||||
bounded phenotype masses, never to caller input, so it is left unsaturated rather
|
||||
than given a branch no test could reach.
|
||||
|
||||
The invariant `held + intake - release == reached` is now asserted per channel for
|
||||
the reviewer's exact case, for the releasing case, across six target sizes by
|
||||
seven growth fractions by four material budgets, and across a forty-step walk from
|
||||
|
||||
Reference in New Issue
Block a user