207f9e6953b0563487f27669fb317b451ffc9513
3
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
14e0c1af5e |
An empty reservoir is not an unowned one
Two defects from review of |
||
|
|
0697895e25 |
A cohort's reserve is the whole of its reservoir, not a part of it
Commit proved the destination reservoir existed and that the registry slot was free, but never that the reservoir was empty. Gathering into an occupied reservoir therefore succeeded and mixed inventory the conversion had never sampled into the cohort's backing store: the cohort's recorded reserve understated what backed it, and the surplus belonged to nobody. Reproduced against the unfixed code rather than taken on trust. Gathering into reservoir 5, which the fixture already seeds with seven picojoules, commits and leaves the ledger holding 67 against a cohort recording 60, exactly as reported. A destination holding anything is refused now. The success test also asserts the destination balance equals the installed cohort's reserve, so the equality is checked rather than assumed, and the regression asserts the refusal leaves the balances, the action counter and the registry as they were, then that emptying the reservoir first makes the same plan committable. The check runs after the staleness loop rather than beside the other destination checks. Both run before anything moves, so it is a reporting choice: replaying a committed plan into a fresh registry would be refused by either, and that the members no longer hold what was sampled says more than that the reservoir is occupied. The guard was confirmed load-bearing by removing it alone. An earlier attempt at that reported it as not load-bearing; that result was void and discarded, because a heredoc had mangled the mutation script and nothing was ever mutated. Second time this quirk has produced a false negative in a sweep, and both times the printed output rather than the exit status is what caught it. Release 35/35, analysis, ASan 35/35 and clang-format all ran and passed here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |
||
|
|
1a59b63c7a |
Refuse the whole conversion rather than drop the inconvenient member
M4.2 moves individuals into the M4.1 record and does only that: no advance, no materialization back, no transfer between habitats, no persistence. Collapse is two phases over one sample. plan_collapse reads the members once and returns an immutable plan that already carries a validated cohort; commit applies exactly that plan and derives nothing, so replaying a committed sample cannot resample, and a record that would not validate fails during planning rather than after the ledger has moved. A controlled, suspended, dead or unsettled member refuses the whole plan instead of being skipped. Filtering would let a caller obtain a plan by omitting whoever was inconvenient, and the result would be indistinguishable from an honest conversion, which is the adversarial selection the model forbids. Ages are carried into declared classes and a member fitting none refuses the plan, so nobody is quietly moved or dropped for having nowhere to go. Reserves are summed per class and never redistributed, so the distribution M4.1 exists to keep survives the move. Conservation runs through the ledger rather than beside it: one atomic transaction, one leg per member, each moving that member's entire reserve, so the conserved total is unchanged by construction. Dual representation is closed from both ends. A member must be emptied exactly, and a reservoir holding anything other than what was sampled makes the plan stale rather than partly applicable. The destination is proved available before anything moves, so no rejection can strand biomass in a reservoir nothing owns. Reversing that order is detected by the tests, which is the point: the ordering prevents the failure rather than a comment claiming it cannot happen. Two gaps are stated rather than implied covered. This cannot tell whether the members offered were all there were, so completeness is the caller's obligation. And emptying a reservoir is not withdrawing the right to use it, because the ledger has no removal. ReservoirId and Transfer gain the defaulted comparisons every other value type here already has, so a plan's legs can be compared. Additive, and ADR-0037 says so rather than claiming no M1 change. All ten guards were confirmed load-bearing by removing each and rerunning. One of my own expectations was wrong rather than the code: a replayed commit reported stale_plan where I expected destination_occupied. Both are pure checks made before anything moves, so only the diagnosis differed; the destination check runs first now, because "this already happened" says more about a replay. Release 35/35, analysis, ASan 35/35 and clang-format all ran and passed here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> |