Review P1: the v2 attribute-only runtime role check accepted a login that inherits pg_write_all_data, which can UPDATE lease rows directly and bypass fencing. apply.sql now audits, on every migrate run, the runtime group and all transitive members: privileged attributes, any membership outside the group (inherited or SET-able), table privileges in evolution (including PUBLIC), CREATE rights and EXECUTE beyond the five fenced functions. 0002 and its checksum are unchanged. CI reproduces the bypass and proves each configuration is rejected and rolled back. Review P2: valid(LeasePolicy) bounds every term by the duration before arithmetic; LeaseAuthority validates durations before deadline math and renewal_unknown ignores impossible (>60s) and fences non-positive requests. Extreme min/max tests reproduce the old UBSan overflow and now pass. Validated: Windows CTest 55/55; WSL Release, clang-tidy and ASan/UBSan private-PostgreSQL suites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
85 lines
5.4 KiB
Bash
85 lines
5.4 KiB
Bash
#!/usr/bin/env bash
|
|
set -euo pipefail
|
|
root="$(cd "$(dirname "$0")/../.." && pwd)"
|
|
prefix="$root/.cache/postgres/install"
|
|
export PATH="$prefix/bin:$PATH"
|
|
export LD_LIBRARY_PATH="$prefix/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
|
|
test_dir="$(mktemp -d /tmp/evo-pg-test.XXXXXXXX)"
|
|
chmod 700 "$test_dir"
|
|
export PGHOST="$test_dir" PGPORT=55432 PGDATABASE=postgres PGUSER="$(id -un)"
|
|
unset PGHOSTADDR PGPASSWORD PGSERVICE PGSERVICEFILE
|
|
initdb -D "$test_dir/data" --no-locale --encoding=UTF8 --auth-local=trust --auth-host=reject > "$test_dir/init.log"
|
|
trap 'pg_ctl -D "$test_dir/data" -m immediate stop > /dev/null || true' EXIT
|
|
pg_ctl -D "$test_dir/data" -l "$test_dir/server.log" -o "-k $test_dir -p 55432 -c listen_addresses=''" -w start
|
|
# Runtime group role receives grants; a separate login inherits only that role.
|
|
psql -X -v ON_ERROR_STOP=1 -c 'CREATE ROLE evo_runtime_test NOLOGIN' \
|
|
-c 'CREATE ROLE evo_runtime_login LOGIN IN ROLE evo_runtime_test'
|
|
export EVO_PG_RUNTIME_ROLE=evo_runtime_test EVO_PG_RUNTIME_USER=evo_runtime_login
|
|
bash "$root/tools/migrate-postgres.sh"
|
|
bash "$root/tools/migrate-postgres.sh" # exact supported upgrade/restart is a no-op
|
|
"${1:?path to evo-postgres-tests}"
|
|
v1_sha="$(sha256sum "$root/migrations/0001_region_bootstrap.sql")"
|
|
v1_sha="${v1_sha%% *}"
|
|
# Migration failure must not publish a partial schema.
|
|
createdb migration_rollback
|
|
if (export PGDATABASE=migration_rollback; psql -X -v ON_ERROR_STOP=1 -1 \
|
|
-v migration_sha=invalid -f "$root/migrations/0001_region_bootstrap.sql"); then
|
|
echo 'Expected failed migration' >&2; exit 1
|
|
fi
|
|
test "$(PGDATABASE=migration_rollback psql -XAtc "SELECT count(*) FROM pg_namespace WHERE nspname='evolution'")" = 0
|
|
# A privileged or owner runtime role is refused and leaves no schema behind.
|
|
if (export PGDATABASE=migration_rollback EVO_PG_RUNTIME_ROLE="$PGUSER"; \
|
|
bash "$root/tools/migrate-postgres.sh"); then
|
|
echo 'Expected privileged runtime role rejection' >&2; exit 1
|
|
fi
|
|
if (export PGDATABASE=migration_rollback EVO_PG_RUNTIME_ROLE=no_such_evo_role; \
|
|
bash "$root/tools/migrate-postgres.sh"); then
|
|
echo 'Expected missing runtime role rejection' >&2; exit 1
|
|
fi
|
|
test "$(PGDATABASE=migration_rollback psql -XAtc "SELECT count(*) FROM pg_namespace WHERE nspname='evolution'")" = 0
|
|
# Supported upgrade path: an existing exact v1 database migrates to v2.
|
|
createdb upgrade_path
|
|
PGDATABASE=upgrade_path psql -X -v ON_ERROR_STOP=1 -1 -v "migration_sha=$v1_sha" \
|
|
-f "$root/migrations/0001_region_bootstrap.sql" > /dev/null
|
|
test "$(PGDATABASE=upgrade_path psql -XAtc "SELECT string_agg(version::text, ',') FROM evolution.schema_migrations")" = 1
|
|
PGDATABASE=upgrade_path bash "$root/tools/migrate-postgres.sh"
|
|
test "$(PGDATABASE=upgrade_path psql -XAtc "SELECT string_agg(version::text, ',' ORDER BY version) FROM evolution.schema_migrations")" = 1,2
|
|
# Inherited privileges bypass fencing, so every migrate run audits effective rights.
|
|
psql -X -v ON_ERROR_STOP=1 -c 'CREATE ROLE evo_bad_runtime NOLOGIN IN ROLE pg_write_all_data'
|
|
if (export PGDATABASE=migration_rollback EVO_PG_RUNTIME_ROLE=evo_bad_runtime; \
|
|
bash "$root/tools/migrate-postgres.sh"); then
|
|
echo 'Expected inherited-privilege runtime rejection' >&2; exit 1
|
|
fi
|
|
test "$(PGDATABASE=migration_rollback psql -XAtc "SELECT count(*) FROM pg_namespace WHERE nspname='evolution'")" = 0
|
|
expect_audit_failure() {
|
|
psql -X -v ON_ERROR_STOP=1 -c "$1"
|
|
if bash "$root/tools/migrate-postgres.sh"; then
|
|
echo "Expected runtime audit failure after: $1" >&2; exit 1
|
|
fi
|
|
psql -X -v ON_ERROR_STOP=1 -c "$2"
|
|
}
|
|
# The reviewed scenario: the login inherits pg_write_all_data and can bypass the guard.
|
|
psql -X -v ON_ERROR_STOP=1 -c 'GRANT pg_write_all_data TO evo_runtime_login'
|
|
PGUSER=evo_runtime_login psql -X -v ON_ERROR_STOP=1 \
|
|
-c 'UPDATE evolution.region_leases SET epoch = 99 WHERE false' > /dev/null
|
|
psql -X -v ON_ERROR_STOP=1 -c 'REVOKE pg_write_all_data FROM evo_runtime_login'
|
|
expect_audit_failure 'GRANT pg_write_all_data TO evo_runtime_login' \
|
|
'REVOKE pg_write_all_data FROM evo_runtime_login'
|
|
expect_audit_failure 'GRANT pg_write_all_data TO evo_runtime_test WITH INHERIT FALSE' \
|
|
'REVOKE pg_write_all_data FROM evo_runtime_test'
|
|
expect_audit_failure 'GRANT UPDATE ON evolution.region_heads TO PUBLIC' \
|
|
'REVOKE UPDATE ON evolution.region_heads FROM PUBLIC'
|
|
expect_audit_failure 'GRANT EXECUTE ON FUNCTION evolution.check_region_lease(evolution.u64, evolution.u64, uuid, evolution.u64) TO evo_runtime_test' \
|
|
'REVOKE EXECUTE ON FUNCTION evolution.check_region_lease(evolution.u64, evolution.u64, uuid, evolution.u64) FROM evo_runtime_test'
|
|
expect_audit_failure 'ALTER ROLE evo_runtime_login CREATEDB' 'ALTER ROLE evo_runtime_login NOCREATEDB'
|
|
bash "$root/tools/migrate-postgres.sh" # Restored configuration passes the audit again.
|
|
# Unknown future versions and checksum drift must not be repaired silently.
|
|
psql -X -v ON_ERROR_STOP=1 -c 'UPDATE evolution.schema_migrations SET version=3 WHERE version=2'
|
|
if bash "$root/tools/migrate-postgres.sh"; then exit 1; fi
|
|
psql -X -v ON_ERROR_STOP=1 -c "UPDATE evolution.schema_migrations SET version=2 WHERE version=3"
|
|
psql -X -v ON_ERROR_STOP=1 -c "UPDATE evolution.schema_migrations SET sha256=repeat('0',64) WHERE version=2"
|
|
if bash "$root/tools/migrate-postgres.sh"; then exit 1; fi
|
|
psql -X -v ON_ERROR_STOP=1 -c "UPDATE evolution.schema_migrations SET sha256=repeat('0',64)"
|
|
if bash "$root/tools/migrate-postgres.sh"; then exit 1; fi
|
|
echo 'postgres migrations, rollback, constraints, permissions and fencing passed'
|