Commit Graph
3 Commits
Author SHA1 Message Date
530b56c33c Fix: ghost-match bug — session stays Active after game ends
Two root causes fixed:

1. Race condition (primary cause): SaveStateAsync committed the
   transaction with Phase=GameOver in StateJson, but session.Status
   was not set to Completed until a separate SaveChangesAsync in
   FinalizeGameAsync. If the server crashed or any exception was
   thrown between those two calls, the session was left Active with
   a GameOver state — causing the "active game" prompt on next login.

   Fix: each game-over handler (concede, force_concede, attack) now
   sets session.Status/WinnerAccountId/WinCondition/EndedAt BEFORE
   calling SaveStateAsync, so all fields commit atomically in the
   same transaction.

2. Wrong save order in FinalizeGameAsync: identityDb.SaveChangesAsync
   (ELO update) ran before gameDb.SaveChangesAsync (Status=Completed).
   Any transient identity-DB error left the session permanently Active.

   Fix: gameDb is saved first; ELO runs after, so a failed ELO update
   never causes a ghost match.

3. Defensive startup heal (GameStartupCleanupService): on server
   start, Active sessions whose StateJson contains Phase=GameOver are
   now detected and marked Completed. game.over is pushed to any
   still-connected clients so they can exit cleanly.

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
2026-03-18 20:02:10 -04:00
fd95cce564 Fix: only abandon Initializing sessions older than 60 s at startup
MatchmakerService is registered before GameStartupCleanupService in
Program.cs. BackgroundService.StartAsync fires ExecuteAsync on a
background thread and returns immediately, so the matchmaker's first
tick runs concurrently with the cleanup's StartAsync. If players were
already in the queue when the process restarted, the matchmaker creates
a fresh Initializing session within the first milliseconds of startup —
and the cleanup's ToListAsync would include it, abandoning a brand-new
session before game.ready could be sent.

Adding a 60-second staleness threshold: sessions younger than 60 s are
left alone; only genuinely stale sessions (from the previous process)
are abandoned. A legitimate game.ready exchange completes in < 10 s, so
60 s is a safe lower bound.

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
2026-03-09 17:23:36 -04:00
5b8f34e794 Fix: abandon stale Initializing sessions on Game startup
When SOR.Game is redeployed, sessions in Initializing status are
unreachable — clients already sent game.ready to the old process and
won't retry. GameStartupCleanupService runs once at startup, marks all
Initializing sessions as Abandoned (WinCondition = "server_restart"),
and pushes game.session_abandoned to both players so clients can return
to the main menu instead of hanging on the loading screen.

Also fix MatchmakerService to include WinnerOpReward, LoserOpReward,
and RankDiffOpMultiplierPct in the rule snapshot so FinalizeGameAsync
picks up the correct OP rewards from the snapshot.

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
2026-03-09 17:12:54 -04:00