Sparse board fixes:
- _bfs_path: skip neighbour tiles not present in _tile_bodies (e.g. Cross
arm corners), preventing movement through void gaps on non-rectangular boards
- _valid_move_tiles: same tile-existence guard before adding candidates
- _attack_range_tiles: same guard for ranged-reach highlights
Camera improvements:
- Auto-scale _cam_distance from board size (max_dim × 1.5, clamped 12–30)
so RadialStar, HexRing and other large boards are fully visible on load
- Camera orientation now uses board.startingZones centroid to derive yaw for
any seat index, enabling correct "look from behind" for seats 2–5 in Cross,
Triangular, RadialStar, and HexRing layouts; falls back to P1/P2 logic when
zones are absent (legacy 1v1 games)
- Pan limits scale with board size (board_half_extent clamped 6–20) instead
of hardcoded ±6 world units, allowing full pan across large boards
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Builder (BoardTemplateBuilderPage):
- ComputeDisplayAffinity: rewritten to exactly mirror AffinitySystem.Resolve.
Was reversed on gateway direction ((Void,Basic)→Gateway, (Basic,Void)→Basic)
and silently returned Void for (Void,Aether) instead of UnstableAether.
- PaintMap: corrected B1/B2 slot assignments to match AffinitySystem.Decompose:
basics now use (Void,Basic), gateways use (Basic,Void), UnstableAether and
Aether both use canonical (Void,Aether).
Client (init_screen):
- Fire BoardTemplateCache.fetch() in parallel with ContentCache.start_sync()
so the template list is populated before the player reaches a lobby screen.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
3rd-player ready-up (two root causes):
- Server: LobbyReadyStatusPush to additional players was deserialized
without PropertyNameCaseInsensitive, so after the 3rd player readied
(converting JSON to camelCase) all subsequent pushes went to Guid.Empty
→ 3rd player never received ready/start notifications
- Client: ready_status push handler treated all non-hosts as "guest",
so i_am_ready was incorrectly set from guestReady for additional players
→ their ready state was clobbered every time host/guest readied
- Server: JoinCustomLobbyResponse now includes IsAdditionalPlayer flag
so the client can correctly distinguish guest from 3rd+ player
Board shape fallback:
- GameEngine.cs 2-player overload and GameReadyHandler N-player path both
now treat "Default"/null BoardShape as AutoShape(playerCount) rather than
hardcoded "Rectangle", fixing old sessions and ranked matches
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- GameEngine.cs: 2-player Initialize overload was hardcoding "Rectangle"
regardless of rules.BoardShape — now uses rules?.BoardShape ?? "Rectangle"
- game_screen.gd: _on_player_eliminated was setting _is_spectating but not
calling _setup_spectator_ui(), leaving eliminated players with no Leave button
- GameGetStateHandler.cs: on reconnect (game.get_state), populate missing
display names from identity DB so old/reconnected sessions show real names
instead of truncated account IDs
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- rules_editor_dialog.gd: add add_option helper, boardShape OptionButton
in BOARD section (Default/Rectangle/Cross/Triangular/RadialStar/HexRing),
and OptionButton branch in _on_confirm
- lobby_room_screen.gd: add boardShape to both rules display dicts
- AbilityBuilder.razor: add help docs for OnUnitSentToDiscard CausedBy field
- GameDbContextModelSnapshot.cs: reflect AddBoardShapeOverride migration
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Server:
- PlayerState: add DisplayName property (populated from identity DB)
- PlayerStateDto: add DisplayName field (falls back to truncated ID)
- GameEngine.ToDto: include DisplayName in player DTO
- GameReadyHandler: resolve display names from identity DB after state
initialization so every subsequent state push carries them
Client:
- Game.gd: add get_display_name(account_id) helper — reads displayName
from player state, falls back to substr(0,8)
- game_screen.gd: replace all 5 pid/eid/elim_id.substr(0,8) UI sites
with Game.get_display_name() — HUD opp name, turn order strip,
game-over outcome list, discard scope selector, elimination dialog
- Turn order strip chips: use resolved display name; add mouse_filter
STOP + tooltip_text showing SP/ST/Hand/Deck for opponent chips on hover
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- GameEngine.Concede: use EliminatePlayer instead of unconditionally
setting GamePhase.GameOver — FFA game continues until one team remains.
Return value changed to (GameState, bool gameOver) tuple.
- GameConcedeHandler / GameForceConcedeHandler: check gameOver flag;
when game continues push BroadcastPlayerEliminatedAsync + state update
instead of calling FinalizeMultiPlayerGameAsync prematurely.
- game_screen.gd _valid_attack_target_coords: use `not (_tpos is Dictionary)`
guard instead of typed assignment — prevents nil crash when eliminated
players' units still appear in get_all_enemy_units() with position:null.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
BoardShapeGenerator: 2-player rectangle now assigns one row per seat
(row 0 for seat 0, top row for seat 1), restoring the original 1v1
behaviour. 3-4 player lobbies keep the two-row zones for extra
placement room.
Game.gd game.over: server sends playerOutcomes:null for 2-player games.
d.get(key, default) returns null when the key exists with value null,
so 'null as Array' crashed. Use 'is Array' guard to safely fall back
to an empty array when the field is absent or null.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
GameLobbyReadyHandler: change else→else if (isGuest) so additional
players (seat 3+) no longer incorrectly set GuestReady=true. When
Player 3 called ready the else-branch marked GuestReady, making the
all-ready check fire as soon as the host was also ready — starting
the game without Player 2 ever clicking ready, leaving 2/3 clients
in a starting state and 1 stuck in the lobby.
Also: update DeckId for additional players in AdditionalPlayersJson;
push ready_status to additional player connections.
GameUnreadyHandler: handle additional players (seat 3+) by updating
isReady in AdditionalPlayersJson via JsonNode; push unready status to
all participants including additional players. Previously threw
NOT_IN_LOBBY for anyone beyond the primary guest.
Game.gd: guard _on_auth_reconnect with 'state is non-empty' so stale
session_id values from ended games don't trigger spurious game.ready
calls. Also clear session_id in the game.over handler so it never
lingers past the end of a session.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- game_screen.gd: fix Parser Error on line 270 — use 'as Environment'
cast instead of ': Variant' annotation for WorldEnvironment.environment
- Game.gd: auto-resend game.ready on auth_success reconnect so the
game session is restored when the WebSocket reconnects mid-game
- lobby_browser_row.gd: show real N/Max player count instead of
hardcoded "1/2" / "2/2"
- CustomLobbyDto: add MaxPlayers, CurrentPlayerCount, GameMode, TeamCount
- GameListCustomLobbiesHandler: compute currentPlayerCount from
GuestAccountId + AdditionalPlayersJson; pass new fields to DTO
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Server:
- BoardDto: add StartingZones (seat → coord list) so client knows valid placement tiles
- GameEngine.ToBoardDto: serialize StartingZones into the DTO
Client – Game.gd:
- get_enemy_players(): returns all players not on the local player's team
- get_all_enemy_units(): flat list of field + archSpirit from all enemies
- game_over signal: adds player_outcomes: Array parameter
- game.over push: extracts playerOutcomes array and passes to signal
Client – game_screen.gd:
- _valid_placement_tiles(): uses board.startingZones[seatIndex] when available; falls back to legacy row logic
- _valid_attack_target_coords/ids: use Game.get_all_enemy_units() instead of single opponent
- ability target picker: uses get_all_enemy_units() for enemy units
- player-panel builder (zone abilities): iterates get_enemy_players() for N-player
- _on_game_over: shows per-player rank deltas from playerOutcomes when present
Client – CustomLobby.gd:
- State: max_players, game_mode, team_count fields (cleared on clear_state)
- create(): accepts p_max_players, p_game_mode, p_team_count params; sends to server
- join(): stores max_players/game_mode/team_count from server response
- game.custom.started: calls clear_state() before emitting game_starting
Client – FreePlayScreen:
- Create dialog: MaxPlayersSpinner (2-10), GameModeOption (FFA/Teams/MultiTeam), TeamCountRow (hidden for FFA)
- GameModeOption.item_selected toggles team_count_row visibility
- _on_create_confirmed: passes max_players, game_mode, team_count to CustomLobby.create()
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- GameEngine: GetNPlayerTurnLimitWinners() ranks surviving players by ArchSpirit HP; highest-HP player(s) win, rest lose
- GameConcedeHandler: N-player path — conceder is loser, remaining non-eliminated players are winners; delegates to FinalizeMultiPlayerGameAsync
- GameForceConcedeHandler: same N-player/1v1 branch split for inactivity forfeit
- GameEndTurnHandler: N-player path uses GetNPlayerTurnLimitWinners + FinalizeMultiPlayerGameAsync on turn-limit game-over
- GameTurnTimerService: same N-player/1v1 branch on timer-expiry game-over
- Game.gd: player_eliminated signal + game.player_eliminated push handler
- game_screen.gd: _on_player_eliminated shows AcceptDialog; sets _is_spectating=true for the local player so they can watch the rest of the game
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
3D (game_screen): _process increments env.sky_rotation.y at 0.026 rad/s
(~4 min per full revolution) — works for all sky types (panoramic,
animated panoramic, cubemap shader) via Godot's built-in EYEDIR transform.
2D (ContentCache): apply_scene_background attaches a canvas_item ShaderMaterial
to the background TextureRect that horizontally scrolls UV.x using the built-in
TIME uniform at 0.004 UV/s (matching the ~4 min cycle) — no GDScript tick needed.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Remove ContentCache.load_texture_async for cubemap faces; ImageTexture.get_image()
silently returns null in some Godot 4 builds, leaving all images[] null
- Fetch each face directly with HTTPRequest (same pattern as _load_static_skybox),
keeping raw Image objects — no GPU round-trip
- Wrap `pending` in Array[1] so closures always capture a reference, not a
stale copy of the int (GDScript 4 primitive closure-capture is unreliable)
- Log warning per face on download or decode failure
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Use Array[Image] for create_from_images() (plain Array causes runtime type error)
- Detect face size from first valid image; resize mismatched faces to match
- Fill missing faces with correctly-sized black placeholder (was 1x1, caused
dimension mismatch when mixed with real faces)
- Check error return from create_from_images and bail on failure
- Update _skybox_sky after cubemap applied so _setup_procedural_sky can clean up
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- GameReadyResponse: add OpponentDisplayName? (populated only on AlreadyStarted)
- GameReadyHandler: inject SorIdentityDbContext; fetch opponent display name when
session is already Active so rejoining clients get the name immediately
- Game.gd: on AlreadyStarted ack, read opponentDisplayName and set Game.opponent_name
before calling _fetch_state() — fixes opponent showing as GUID on rejoin
- game_screen.gd: replace typed-Dictionary null assignment with safe Variant check
to avoid silent GDScript coercion when no skybox is configured; strip query-string
from URL before extension check (_fetch_skybox); add print logging throughout CDN
skybox flow to surface download/decode failures
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- CustomLobbyGuestJoinedPush: add GuestDisplayName (host now sees guest's real name)
- JoinCustomLobbyResponse: add HostAccountId/Name + GuestAccountId/Name so guest
lobby room shows correct state instead of "Waiting for guest…"
- CustomLobbyGameStartedPush: add OpponentDisplayName so game screen shows name not GUID
- GameJoinCustomLobbyHandler: use 3-tier rules fallback (lobby override → db custom-default
→ hard-coded default) matching StartGameAsync, fixing inconsistent rule display on join
- GameLobbyReadyHandler: inject SorIdentityDbContext, fetch display names for both
players before pushing game.custom.started
- CustomLobby.gd: set Game.opponent_name on game.custom.started push; emit display
names in guest_joined and game_starting signals; patch join response lobby dict
- lobby_room_screen.gd: use display name in _on_guest_joined; update _on_game_starting signature
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Bazaar Deck tab crash: null-safe float conversion for usdPrice in store_item_row.gd
- Leaderboard crash: freed-object guard in _on_leaderboard_ok (is_instance_valid check)
- Add ModifyMinAttackRangeEffect / ModifyMaxAttackRangeEffect with clamp-to-0 and correct reversal tracking
- AbilityBuilder: add new range effects to Stat Modification group + _amountOnlyTypes
- collection.set_arch_spirit: new handler, request record, and service registration
- Deck editor: show Tier-1 commander row with Change button + ArchSpirit picker panel
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Replace the sync card count with a ProgressBar that pulses
indeterminately during version check, then fills 5→85% during
content sync, 90% during active-session check, 100% on done.
Add an 8-second timeout on version.check so a silent server-side
hang (server receives packet but never replies) auto-proceeds to
sync instead of freezing the init screen indefinitely.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Highlights were clipping into tile tops ~half the time because
_tile_heights stores the collision box height (random 0.8-1.0),
but _fit_model_to_tile scales 3D models to their XZ footprint —
so a taller-than-wide model ends up visually taller than the box.
Also fixes _update_hover nil crash: tile.get("occupantId", "")
returns null (not "") when the key exists with a null server value.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Server / DB:
- New HighlightConfig entity (catalog.highlight_configs): one row per
highlight type (Movement/Attack/Ability/Terramorpha/Selector). Supports
static texture URL or animated (base folder + frame count + FPS) with a
FallbackHex RGBA colour for when no texture is configured.
- EF migration AddHighlightConfig.
- CosmeticType.HighlightPack added; AssetCdnUrl stores serialised JSON with
per-type texture config so players can buy full highlight packs in the Bazaar.
- content.get_highlight_config handler in SOR.Content; response DTOs added to
ContentMessages.cs; handler registered in ServiceRegistration.
Admin:
- /content/highlights page: inline editor for all five highlight types
(CDN path, animated toggle, frame count, FPS, fallback hex with swatch).
Upserts rows — no delete needed since there is always exactly one row per type.
- Highlights nav link added to Content section in NavMenu.
- CosmeticEditor: HighlightPack type renders a per-type table (Movement/
Attack/Ability/Terramorpha/Selector), serialising to JSON in AssetCdnUrl.
Client (Godot):
- HighlightConfig autoload: fetches content.get_highlight_config on startup,
caches to user://highlight_config.json. Provides get_texture(type) and
get_color(type). Supports set_override/clear_override/apply_cosmetic_pack
for cosmetic and settings overrides.
- Settings autoload: highlight_overrides Dictionary persisted in settings.cfg.
set_highlight_override/clear_highlight_override push into HighlightConfig.
- settings_screen.gd: programmatic "Highlight Texture Overrides" section added
with a LineEdit + Reset button per type; appended to Sections VBoxContainer.
- game_screen.gd:
• _add_highlight() rewritten to use flat PlaneMesh quads with textured
StandardMaterial3D. Accepts a string type key ("movement", "attack",
"ability", "terramorpha", "selector") instead of a Color constant.
• _cursor_highlight + _hover_team_overlay: two permanently-allocated quads
that are never freed. The selector highlights the tile under the mouse at
all times; the team overlay shows a coloured tint when hovering an occupied
tile. Both are preserved across _clear_highlights() and _build_board().
• _update_hover(): called on every InputEventMouseMotion event. Moves the
selector quad, shows the team-colour overlay when hovering an occupied tile,
and boosts MeshInstance3D emission on the hovered unit via
set_surface_override_material (reset when hover leaves).
• All existing _highlight_tiles() / _add_highlight() callers updated from
HI_* Color constants to type key strings.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- AbilitySystem.cs: ActivateAbility was only searching player.Field for the
source unit, but player.ArchSpirit is stored in a separate field and was never
checked. Active abilities on an ArchSpirit now work correctly.
- game_screen.gd: Add "Target" to auto_ownerships so the client skips the
player-picker UI for Ownership:Target actions. The server auto-resolves them
from ctx.ResolvedTargets (the owner of the previously targeted card), which
is exactly what Bounce needs: refund SP to the owner of the returned spirit
without asking the user to choose a player.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
@onready vars are resolved when a node enters the scene tree. Calling setup()
before add_child() means all %NodeName refs are still null, causing
"Invalid assignment... on base object of type Nil" errors.
Fixed ordering in every affected screen:
- free_play_screen.gd: LobbyBrowserRow, ActiveGameRow, DeckPickerButton
- lobby_room_screen.gd: RulesEditorDialog
- matchmaking_screen.gd: DeckPickerButton
- card_detail_popup.gd: StatRow, AbilityRow
- starter_deck_screen.gd: StarterDeckCard
- account_screen.gd: NotificationRow
- leaderboard_screen.gd: LeaderboardRow
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- All game action handlers: move ToDto() call to after SaveStateAsync()
so the ACK's StateVersion matches the pushed delta (stale-version fix)
- GameHandlerBase.PushStateToPlayersAsync: add empty-delta safety fallback
— when ComputeDelta() returns all-null content fields, fall back to a
full game.state_update push so clients always see the correct state
- Add Console.WriteLine diagnostics to PushStateToPlayersAsync to expose
prev/next phase, turn, active player, and whether prevStateJson matches
the post-mutation session.StateJson (root cause investigation)
- Game.gd: wire game.activity push to game_activity signal
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Convert all screens that built UI nodes in GDScript into proper .tscn
scene files. Each component gets its own scene; parent screens use
preload + instantiate; data flows through setup() methods; actions use
signals. Eliminates ~1000 lines of boilerplate node-creation code.
Phase 1 — Simple row components (6 new scenes):
LeaderboardRow, NotificationRow, StarterDeckCard, DeckPickerButton,
StatRow, AbilityRow
Modifies: leaderboard_screen, account_screen, starter_deck_screen,
matchmaking_screen, card_detail_popup (GridContainer→VBox)
Phase 2 — Lobby browser rows (2 new scenes):
LobbyBrowserRow (signal join_requested), ActiveGameRow (signal spectate_requested)
Modifies: free_play_screen
Phase 3 — RulesEditorDialog (1 new scene):
Replaces 150+ line _open_rules_editor() in lobby_room_screen with
4-line instantiate pattern; signal confirmed(overrides)
Phase 4 — DeckEditorPanel.tscn:
Moves split-pane deck editor into scene file; removes _setup_ui(),
_make_left_pane(), _make_right_pane(); switches to @onready refs;
DecksView.tscn updated to instance the scene
Phase 5 — ChatOverlay.tscn:
Fully populates ChatPanel with header, 7 tab buttons, 7 content panes
(FriendsPane/PresencePane/GlobalPane/LobbyPane/GamePane/PartyPane/DmsPane),
and InputBar; removes _build_panel() and all _make_*/_build_*_tab()
functions from chat_overlay.gd; replaces with @onready refs and
_ready() wiring from scene children
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>