- game.custom.get returns full CustomLobbyDetailDto: all effective rules (overrides
merged with GameRules.Default), host/guest account IDs, status, GameSessionId.
- CustomLobbyDetailDto includes Status string, GuestAccountId (nullable),
GameSessionId (nullable); richer than the browse-list CustomLobbyDto.
- GetCustomLobbyRequest / GetCustomLobbyResponse added to GameMessages.cs.
- ServiceRegistration: registered GameGetLobbyHandler as transient IMessageHandler.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- VoteSessionService singleton: ConcurrentDictionary<Guid, ActiveVote> keyed by lobbyId.
TryStart prevents concurrent votes; Cast resolves immediately on any rejection or all approval.
- GameSavePresetHandler (game.custom.preset.save): captures lobby override columns into
CustomRulesOverride JSON and persists as LobbyPreset; participants only.
- GameListPresetsHandler (game.custom.preset.list): returns all presets owned by caller.
- GameDeletePresetHandler (game.custom.preset.delete): owner-only delete.
- GameProposePresetHandler (game.custom.preset.propose): host-only in Full lobby;
starts vote with guest as sole voter; pushes game.custom.preset.vote_requested to guest.
- GameVotePresetHandler (game.custom.preset.vote): casts yes/no;
Approved → applies preset overrides to lobby DB + pushes game.custom.lobby_updated to both;
Rejected → pushes game.custom.preset.vote_rejected to both.
- GameMessages.cs: SavePreset/ListPresets/DeletePreset/ProposePreset/VotePreset
request/response types; LobbyPresetDto; PresetVoteRequestedPush, LobbyUpdatedPush,
PresetVoteRejectedPush.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- SpectatorRegistryService singleton: ConcurrentDictionary<Guid, ImmutableHashSet<Guid>>
tracking spectators per session. Static Instance for use in static base-class helpers.
- GameEngine.ToDtoSpectator: delegates to ToDto(state, "") — both hands hidden.
- GameHandlerBase.PushStateToPlayersAsync: extended to push hand-hidden state_update
to all registered spectators via SpectatorRegistryService.Instance.
- GameHandlerBase.FinalizeGameAsync: pushes game.over to spectators then calls
RemoveSession to evict the entry from the registry.
- GameSpectateHandler (game.spectate): validates session Active, registers spectator,
returns current spectator-view state as ack.
- GameStopSpectatingHandler (game.spectate.stop): unregisters the caller.
- GameMessages.cs: SpectateRequest/Response, StopSpectatingRequest/Response.
- ServiceRegistration.cs: register SpectatorRegistryService singleton + both handlers.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Phase 2 — GameEngine:
- Draw(): now draws DrawPerTurn+DrawPerTurnBonus cards per call (was always 1);
enforces HandSizeCap with block-draw or auto-discard (DiscardOnMaxHand)
- EndTurn(): returns (GameState, bool gameOver); applies MpBuff to all next-player
units at turn start; checks TurnLimit and sets GameOver phase if exceeded
- GetTurnLimitWinner(): helper returning winner/loser by ArchSpirit HP (P1 on tie)
- ValidateDeck(): new public method checking MinDeckSize, MaxDeckSize, MaxArchTier1
- GameRules note: new fields are already in place from Phase 1
Phase 7 — Handlers + Messages:
- CustomRulesOverride: +9 new nullable fields (HandSizeCap, DiscardOnMaxHand,
MaxDeckSize, MinDeckSize, MaxArchTier1, TurnTimerSeconds, TimeLimitMinutes,
TurnLimit, MpBuff)
- CustomRulesDto: +9 matching fields + HasPassword bool
- CreateCustomLobbyRequest: +Password field
- JoinCustomLobbyRequest: +Password field; handler now validates password
- ListCustomLobbiesRequest: +NameSearch, ShowPasswordProtected filters
- GameCreateCustomLobbyHandler: full rule merge + ToDto covers all new fields
- GameJoinCustomLobbyHandler: password check + full rules construction incl. new fields
- GameListCustomLobbiesHandler: full DTO mapping + NameSearch/password filters
- GameEndTurnHandler: injected identityDb+eventBus; handles TurnLimit game-over
using same pattern as GameAttackHandler (set session fields before SaveStateAsync)
- GameDrawHandler: update deconstruct to discard unused drawn list (_)
- CustomLobbyGuestJoinedPush: new push type (used in Phase 6)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Extend CustomLobby with 12 new rule override columns (Password,
HandSizeCap, DiscardOnMaxHand, MaxDeckSize, MinDeckSize, MaxArchTier1,
TurnTimerSeconds, TimeLimitMinutes, TurnLimit, MpBuff, BoardWidth/Height)
- Extend GameRuleSet with matching non-nullable rule fields (same set)
- Extend GameRules record with 9 new rule fields (all default to 0/false)
- Add LobbyPreset entity (owner-scoped named rule presets)
- Register LobbyPreset in GameDbContext with index on OwnerAccountId
- Migration: AddCustomGameExtensions (applied to pg-forge-01)
- Add custom-game-system-plan.md with full 8-phase architecture plan
and deferred features tracking list
- Also includes: AbilityBuilder ValueExpr dropdowns + help panel,
Affinity enum/system fixes (from prior sessions)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Two root causes fixed:
1. Race condition (primary cause): SaveStateAsync committed the
transaction with Phase=GameOver in StateJson, but session.Status
was not set to Completed until a separate SaveChangesAsync in
FinalizeGameAsync. If the server crashed or any exception was
thrown between those two calls, the session was left Active with
a GameOver state — causing the "active game" prompt on next login.
Fix: each game-over handler (concede, force_concede, attack) now
sets session.Status/WinnerAccountId/WinCondition/EndedAt BEFORE
calling SaveStateAsync, so all fields commit atomically in the
same transaction.
2. Wrong save order in FinalizeGameAsync: identityDb.SaveChangesAsync
(ELO update) ran before gameDb.SaveChangesAsync (Status=Completed).
Any transient identity-DB error left the session permanently Active.
Fix: gameDb is saved first; ELO runs after, so a failed ELO update
never causes a ghost match.
3. Defensive startup heal (GameStartupCleanupService): on server
start, Active sessions whose StateJson contains Phase=GameOver are
now detected and marked Completed. game.over is pushed to any
still-connected clients so they can exit cleanly.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Client: Repentance/Instinct cards with Active abilities in abilitiesJson now
enter ABILITY_TARGET mode instead of sending play_card immediately. Units on
matching tile affinities (IsOnTileWithAffinity) are highlighted in blue; the
player clicks a target unit and the card is sent with the selected unit target.
Server: FireCardEffects now also processes Active abilities from AbilitiesJson
(after the existing EffectsJson path). Source-side ActivationConditions are
checked; target-side conditions (Subject=Target) are trusted from the client.
New Game.gd helper: send_play_card_with_targets sends play_card with a targets
array so the server can route unit selections to the active ability handler.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Issue 1 — ActivationConditions on passives were never checked:
- ApplyPassivesForSource and ApplyPassivesToNewTarget now evaluate
ActivationConditions against the source unit before executing each
passive ability (e.g. IsOnTileWithAffinity: Lake only grants the buff
when the unit is actually on a Lake tile).
Issue 1 — Passives not re-evaluated on movement / tile changes:
- Added ReEvaluateConditionalPassives(state): for every unit with at
least one conditional passive, revoke all WhileSourceOnBattlefield
effects then reapply with conditions re-checked. Units without
conditional passives are skipped with zero overhead.
- Called after MoveUnit (unit changes tile affinity),
ActivateAbility (ability may change board state),
and ChannelCard Terramorpha path (tile affinities change).
Issue 2 — INSUFFICIENT_TARGETS thrown from ApplyPassivesToNewTarget:
- ResolveTargets: when restrictTargets is set (passive-to-new-target
mode only) and filtering produces zero candidates, return [] silently
instead of throwing. An ExactSelf source-buff simply has no valid
target among the new unit — that is expected, not an error.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
When admin replaces a model/art file via the CDN browser, the S3 ETag is
now captured and stored on CardAsset.ContentETag. The ETag is included in
the content sync DTO (CardAssetDto) so clients receive it on every sync.
Client-side ModelCache now keys its disk cache on sha256(url + "#" + etag)
instead of sha256(url), so updating a file at the same CDN path busts the
disk cache automatically. A _CACHE_VER="v2" sentinel purges old-scheme
.bin files on first launch after the client update.
Changes:
- CdnUploadResult: add string? ETag field
- S3CdnClient: capture ETag from PutObjectAsync response
- CardAsset: add string? ContentETag property
- Migration 20260318000001_AddAssetContentETag: add content_etag text column
- ContentMessages: add string? ContentETag to CardAssetDto
- ContentDtoMapper: map ContentETag in CardAsset → CardAssetDto
- CdnBrowser.razor: UploadFileToKeyAsync returns Task<string?> (ETag);
ReplaceAsync calls PropagateAssetETagAsync which updates CardAsset rows
and touches CardDefinition.UpdatedAt to trigger a version bump
- ModelCache.gd: versioned disk key + cache migration + etag parameter on
load_model() and evict()
- game_screen.gd: pass model_asset.contentETag to load_model / retry chain
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
AbilityDefinition gains an optional Duration property. When set it is used
as forceDuration for every ExecuteActions call that resolves that ability,
overriding whatever per-action Duration individual effects specify.
- Active abilities: def.Duration is threaded through as forceDuration
- Triggered abilities: same
- Passive abilities: def.Duration ?? WhileSourceOnBattlefield (both
ApplyPassivesForSource and ApplyPassivesToNewTarget paths)
AbilityBuilder admin panel:
- Duration row added after type-specific fields (dropdown + N input for ForNTurns)
- "WhileSourceOnBattlefield" added to the DurationTypeValues list
- Parse and compile paths updated for the new Duration field
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
The attack resolution and sacrifice paths in GameEngine.cs bypassed
RevokePassivesForSource (and EvaluateAurasOnLeave for combat deaths).
Now all three exit points call both aura/passive cleanup before removing
the unit from the board.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
DefinitionToInstance and ToFieldCard both omitted copying Genus, so
HasGenusCondition and GenusContainsFilter always evaluated against null
(returning false). All three data-flow gaps are now fixed:
- DefinitionToInstance: def.Genus?.ToList() → CardInstance.Genus
- ToFieldCard: source.Genus?.ToList() → FieldCard.Genus
- FilterMatches: GenusContainsFilter now handled (was falling to _ => true)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Passive abilities (e.g. 'All Merfolk +1 attack') were never executed
because AbilityType.Passive had no runtime processing.
Three root causes fixed:
1. Passive abilities are now applied when units enter the battlefield
and reversed when they leave (new DurationType.WhileSourceOnBattlefield).
- ApplyPassivesForSource: runs a unit's passives against all current targets
- ApplyPassivesToNewTarget: applies existing passives to a newly-entered unit
- RevokePassivesForSource: reverses all passive effects on source death/leave
- Hooked into GameEngine.Channel, Transition and AbilitySystem
ReturnToBattlefield, SummonToken, KillUnit, SendToDiscard
2. Action conditions with Subject="Target" now filter per-target instead of
aborting the entire action (which evaluated against ctx.Source).
Source-level conditions still gate the whole action; target-level ones
are evaluated individually and skip non-matching targets.
3. ExecuteActions/ResolveTargets gain a restrictTargets parameter used by
ApplyPassivesToNewTarget to avoid double-applying existing passive buffs
to units that already received them when the passive source entered.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Replace raw JSON textarea for trigger event with per-type dropdown
and input fields. Each of the 39 trigger types now renders only its
relevant fields (Player, Ownership, SourceOwnership, TargetOwnership,
UnitType, CardType, DamageType, Amount, Stat, Cause, CausedBy,
RuinOwnership, OccupantOwnership, UnitOwnership, AuraOwnership).
- AbilityDraft gains 15 structured trigger fields replacing TriggerJson
- RenderTriggerFields: per-type RenderFragment (mirrors RenderConditionFields)
- CompileTrigger: builds TriggerEvent JsonObject from draft fields
- ParseJson: reads all trigger fields from existing TriggerEvent JSON
- SelectTrigger: resets all fields to sensible defaults on type change
- New helpers: BuildStringInput, BuildOptionalAmountInput, BuildOptionalStringSelect
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
**Feature 1 — Model retry (client)**
- `ModelCache.gd`: add `evict(url)` to remove failed entries so re-download is possible
- `game_screen.gd`: when GLB load fails, `_schedule_model_retry` queues a 60-second
retry (up to 10 attempts); `_do_model_retry` evicts + re-downloads and swaps the
placeholder mesh for the real model if/when it succeeds
**Feature 2 — Rejoin on login (server + client)**
- Server: `GameGetActiveSessionHandler` (`game.get_active_session`) — returns the
caller's active session ID + phase, or null when no session exists
- Client: `init_screen.gd` checks for an active session after content sync; shows
a "Rejoin / Concede" dialog when one is found; rejoin navigates to GameScreen with
the session ID already set so `send_ready` → `AlreadyStarted` → `_fetch_state`
**Feature 3 — 5-minute inactivity detection (server + client)**
- `GameSession`: add `LastActionAt` column + EF migration
(`20260317000001_AddLastActionAt`)
- `GameHandlerBase.SaveStateAsync`: sets `session.LastActionAt` on every action
- `GameInactivityMonitorService`: background poll every 60 s; when a session hasn't
had an action in ≥ 5 min, pushes `game.inactive_warning` to the stalled player and
`game.opponent_inactive` to their opponent (once per session per server lifetime)
- `GameForceConcedeHandler` (`game.force_concede`): lets the waiting player claim
the win; validates caller is not the active player and `LastActionAt` is stale
- `Game.gd`: new `opponent_inactive` / `inactive_warning` signals + push handlers +
`send_force_concede()` helper
- `game_screen.gd`: handles `opponent_inactive` with Accept/Wait dialog;
handles `inactive_warning` with informational popup
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Replace the plain hex text input + static swatch with a native
<input type="color"> (Bootstrap form-control-color) + text field
combo. Clicking the swatch opens the browser's colour picker and
updates the hex field in real-time. An × button clears the value
back to null (no tint). The text field still accepts manual hex
entry and the picker reflects the change on the next interaction.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Move Scale and Tint Colour from Basic tab into Assets tab under a
new "3D Model Config" section (defaults: Scale=null→1.0, Tint=null)
- Model3D assets: folder icon opens a CDN picker modal that lists all
*.glb / *.gltf from the models/ bucket (cached after first load),
filterable by filename, with a list-group UI
- Art2D assets: same picker pattern but pulls from cardart/ bucket and
shows image thumbnails in a responsive grid
- Model3D inline 3D preview via <model-viewer> appears below the URL
when set; "Load animations" button invokes the same JS interop as
CdnBrowser and populates an animation dropdown
- Art2D inline image preview appears below the URL when set
- Changing or uploading a URL clears cached animation state so the
Load button reappears for the new file
- JS guard (window.sorCdn = window.sorCdn || {}) prevents double-
definition when CdnBrowser is also loaded in the same session
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Visual changes (client):
- 0.1 gap between all tiles (TILE_SPACING = 1.1)
- Placeholder tiles (no 3D model) are now 0.5 height instead of random
0.8-1.0, making undecorated tiles visually distinct
- Placeholder tiles load a 2D CDN texture via HTTP and apply it as the
albedo on the BoxMesh (same affinity-per-shape lookup as 3D models)
- Placeholder tiles also attach a stalagmite bottom model, matching the
look of fully-decorated tiles
Server:
- TileModelBinding.TexturePublicUrl (nullable text) added to entity,
migration 20260317000001_AddTileTexture applied to DB
- TileModelDto extended with TexturePublicUrl
- ContentGetTileModelsHandler includes TexturePublicUrl in response
Admin (/content/tile-models):
- New "Square Texture" and "Hex Texture" columns in the bindings table
- Texture picker modal browses the CDN textures/ prefix and shows image
thumbnails; select + assign writes TexturePublicUrl to the binding
- Texture can be assigned without a 3D model (creates a binding row
with empty model fields)
ContentCache:
- Caches texturePublicUrl alongside modelPublicUrl from tile_models response
- New get_tile_texture_url(affinity, shape) → String accessor
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
## Tile height variation (fix)
Tile tops now visibly vary (0.8–1.0) from a fixed bottom at world Y=0.
Previously the top was fixed and the variation was only visible underneath.
Heights are seeded by tile coordinate so they're deterministic per board.
Unit y_offsets and highlight positions update to match per-tile height.
## Stalagmite tile bottoms
Server: new TileBottomModel entity + migration (catalog.tile_bottom_models),
content.tile_bottoms handler returns all active CDN URLs.
Admin: "Tile Bottom Models" section in the Tile Model Manager page —
add/toggle active/delete entries with CDN picker.
Client: ContentCache fetches + disk-caches the URL pool; _try_load_tile_model
picks a random URL and attaches it flipped below the tile model as a
stalagmite using the existing _fit_model_to_tile scale logic.
## Live content refresh
ContentCache schedules start_sync() every 5 minutes after sync_complete so
card definitions, tile models, and bottom models are refreshed in the
background without restarting the client.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Uploading a replacement GLB with changed animation names to the same
folder/fileName path silently overwrote the S3 object but left the URL
unchanged. ModelCache keyed its disk cache and in-memory cache by URL,
so all clients continued loading the stale model indefinitely.
Fix (CardEditor.razor):
- Asset uploads: append _yyyyMMddHHmmss timestamp to the filename stem
before calling UploadAsync, e.g. merlock_20260316_143022.glb.
- Animation uploads: same treatment.
- Result: every upload produces a unique URL; the card asset record is
updated to that URL; ModelCache sees a new key and fetches fresh bytes.
Fix (HttpCdnClient.cs):
- Set Cache-Control: public, max-age=31536000, immutable on uploaded
objects. Since keys are now unique-per-upload, aggressive caching is
safe and avoids unnecessary re-downloads of unchanged assets.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Model facing: GLB models exported from Blender arrive in Godot facing +Z,
not -Z. Changed _facing_to_base_angle default case from 0 (north/-Z) to
PI (south/+Z). Explicit "north" case added. Updated admin dropdown label
from "Default (north)" to "Default (south / Blender GLB)" to match.
Stale game state: when matchmaking.match_found is received, clear Game.state
so the new GameScreen always calls send_ready() rather than rendering the
previous (ended) game's state. Fixes same-players-re-match ending up in
the already-completed session.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
SERVER
- CardAsset gains ModelFacingDirection (string?), ModelScale (float?),
ModelTintColor (string?), ModelTintMaskUrl (string?) columns.
- CardAssetDto and ContentDtoMapper updated to expose them.
- EF migration AddModelConfig applied to pg-forge-01 / SOR DB.
CLIENT (game_screen.gd)
Animation loop:
- GLB standard: first 5 frames (ANIM_TRANSITION_SECS = 5/30s) are
entry frames that blend from idle into the action. Looping
animations now skip those frames on every iteration after the
first, eliminating the bind-pose flash at the loop seam.
- Manual loop management via animation_finished + CONNECT_ONE_SHOT
replaces LOOP_LINEAR so the seek-past-transition trick works.
- _idle_callbacks tracks active loop callables so they can be
disconnected when a one-shot animation interrupts idle.
- _idle_entry_done reset when a one-shot starts so the transition
frames play correctly when returning to idle after the action.
Model config:
- _find_model3d_asset() replaces _find_model3d_url() — returns the
full asset dict including the new fields.
- ModelFacingDirection → _facing_to_base_angle() → rotation.y applied
at load; stored in _model_base_angles for movement / idle reset.
- ModelScale applied uniformly to model_node.scale on load.
- ModelTintColor applied as multiplicative albedo_color tint to all
StandardMaterial3D surfaces (materials duplicated per-instance).
- ModelTintMaskUrl stored in DB/DTO; per-texel shader not yet wired.
Movement facing:
- _animate_unit_move pre-computes a facing angle per BFS step and
snaps model_node.rotation.y at the start of each step so units
face the direction they walk.
- On movement end, rotation resets to the idle/team direction.
Cleanup:
- _rebuild_units removal loop erases _idle_entry_done, _idle_callbacks,
_model_base_angles, _needs_face_rot for freed units.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Rapid echo state-updates (phase-change, turn-tick) arriving with
delay=0 used to cancel the pending movement tween, making unit travel
instant. Now a delay=0 call only updates _pending_rebuild so the
latest state is applied when the existing tween fires; the tween is
only cancelled when a new positive delay arrives.
Also: password min-length 12→8 (auth), anchor preset cleanup (tscn).
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
CORS: Access-Control-Allow-Origin must be set before the CDN GetAsync
call so it is present even if the upstream throws (ASP.NET Core exception
handling resets responses, dropping headers set after an exception).
Added try/catch to return 502 cleanly on upstream failures.
Debug: [Move] prints in _play_move_animations and _schedule_rebuild to
diagnose why movement animation appears instant.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Server:
- CardAnimationBinding.AnimationTrackName: nullable override for GLB track name
(blank = case-insensitive convention match; Idle/Attack/Damaged/Moving/Dying)
- CardAnimationBindingDto: includes AnimationTrackName in content sync
- CardEditor: GLB Track Name column in animation bindings table
- CdnBrowser: model-viewer animation list + playback (JS interop on load event)
- Migration: AddAnimationTrackName applied to production
Client:
- ContentCache.get_anim_track(): resolves GLB track name from binding override
or falls back to convention with case-insensitive aliases
- game_screen.gd:
- _find_animation_player(): recursive search in loaded GLB scene tree
- _resolve_anim_track(): case-insensitive + alias resolution
- _play_unit_anim(): plays track, returns to Idle when one-shot finishes
- _play_damage_animations(): detects HP drops and unit deaths before rebuild
- Model facing: P1 units rotated 180deg Y to face opponent across board
- Idle loop starts automatically after real model loads
- Attack animation fires immediately on attack input (before ACK)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- AbilitySystem: implement WithinRangeFilter (Manhattan distance min/max) and
IsAdjacentToSourceFilter in FilterMatches — both were falling through to
_ => true, so range constraints on targeting were silently ignored
- Program.cs: add GET /cdn/{**path} proxy endpoint with
Access-Control-Allow-Origin: * so browser web clients can fetch GLB models
(Ceph RadosGW / cdn.aeternalisgames.com has no CORS headers)
- ModelCache.gd: on web export, rewrite cdn.aeternalisgames.com URLs to go
through hub.aeternalisgames.com/cdn proxy; disk/memory cache still keyed
on the original CDN URL for consistency across platforms
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
BuildCandidates only added p.Field to the candidate pool for
Scope=Battlefield, leaving p.ArchSpirit (stored as a separate
PlayerState property) out. A Unit-typed ability targeting the
opponent's ArchSpirit would match zero candidates → INSUFFICIENT_TARGETS.
Also include p.ArchSpirit in the AnyZone pool for consistency.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
[JsonDerivedType] alone (without [JsonPolymorphic]) is sufficient in .NET 8 to
activate the built-in PolymorphicTypeResolver, which then throws
NotSupportedException because our custom converter does not support metadata
reads/writes.
Introduce PolyTypeAttribute — a plain internal attribute unknown to the
framework — and replace all [JsonDerivedType] usages on Effect, Condition,
TriggerEvent, and Filter with [PolyType]. PolymorphicAbilityConverter<T> reads
[PolyType] via reflection to build its type map; the framework ignores it entirely.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Having both [JsonPolymorphic] on the class AND a custom JsonConverter<T> in options
causes NotSupportedException: the built-in polymorphic resolver tries to configure
alongside the custom converter but requires it to support metadata reads/writes.
Our custom PolymorphicAbilityConverter<T> takes full ownership of polymorphic
dispatch, so [JsonPolymorphic] is redundant. The [JsonDerivedType] attributes
remain — our converter reads them via reflection for the type map; the framework
ignores them without [JsonPolymorphic] present.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Refactor EffectPolymorphicConverter into a generic PolymorphicAbilityConverter<T>
base class, add concrete converters for all four abstract ability model types:
Effect, Condition, TriggerEvent, and Filter — all share the same abstract +
[JsonPolymorphic] pattern and the same ordering constraint from the admin builder.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
[JsonPolymorphic] on an abstract base class requires $type to appear first in
the JSON object. Card abilities authored in the admin tool don't guarantee this
ordering (e.g. {"N":1,"$type":"DrawCards","Player":"Owner"}), causing a
NotSupportedException at ParseAbilities time.
Add EffectPolymorphicConverter which overrides CanConvert to intercept only
typeof(Effect) (not concrete derived types). It buffers the full JSON object,
finds $type at any position, looks up the concrete type from the [JsonDerivedType]
attribute map, then deserializes via the default converter. Because CanConvert
returns false for concrete types, there is no infinite recursion even for nested
Effect[] (e.g. ApplyOnEventEffect.Effects).
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Both players navigate to the game screen at the same time after match_found
and both send game.ready concurrently. Without row-level locking, each request
reads the other player's ready flag as false before the other's SaveChanges
commits, so neither handler ever sees both flags set — both return
WaitingForOpponent and the session stays Initializing forever.
Fix: wrap GameReadyHandler in an explicit transaction with SELECT … FOR UPDATE,
matching the same locking pattern already used by LoadActiveSessionAsync for
active-game mutations. The second request now blocks until the first commits,
then reads the updated ready flag and proceeds to initialize.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
MatchmakerService is registered before GameStartupCleanupService in
Program.cs. BackgroundService.StartAsync fires ExecuteAsync on a
background thread and returns immediately, so the matchmaker's first
tick runs concurrently with the cleanup's StartAsync. If players were
already in the queue when the process restarted, the matchmaker creates
a fresh Initializing session within the first milliseconds of startup —
and the cleanup's ToListAsync would include it, abandoning a brand-new
session before game.ready could be sent.
Adding a 60-second staleness threshold: sessions younger than 60 s are
left alone; only genuinely stale sessions (from the previous process)
are abandoned. A legitimate game.ready exchange completes in < 10 s, so
60 s is a safe lower bound.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
When SOR.Game is redeployed, sessions in Initializing status are
unreachable — clients already sent game.ready to the old process and
won't retry. GameStartupCleanupService runs once at startup, marks all
Initializing sessions as Abandoned (WinCondition = "server_restart"),
and pushes game.session_abandoned to both players so clients can return
to the main menu instead of hanging on the loading screen.
Also fix MatchmakerService to include WinnerOpReward, LoserOpReward,
and RankDiffOpMultiplierPct in the rule snapshot so FinalizeGameAsync
picks up the correct OP rewards from the snapshot.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- ChatChannel: add ArchivedAt (nullable DateTimeOffset)
- ChatChannelMembership.EndMatchMembershipsAsync: set channel.ArchivedAt
so match channels are archived when games end
- GameHandlerBase.FinalizeGameAsync: add IEventBus param; compute
OriginPoints rewards scaled by rank diff; publish GameEndedEvent so
ChatLifecycleHostedService triggers archival
- GameRuleSet: add WinnerOpReward (50), LoserOpReward (10),
RankDiffOpMultiplierPct (0) with NOT NULL + defaults
- GameMessages.GameOverPush: add WinnerOpDelta / LoserOpDelta fields
- GameConcedeHandler + GameAttackHandler: inject IEventBus, pass to
FinalizeGameAsync
- Migrations: 20260309200000_AddArchivedAtToChatChannel (ChatDbContext),
20260309210000_AddOpRewardFields (GameDbContext)
- Admin GameSessionsPage: inject ChatDbContext; purge Match channels
before deleting sessions in PurgeAllAsync
- Admin RankedRulesPage: new "Origin Points Rewards" card with three
number inputs (WinnerOpReward, LoserOpReward, RankDiffOpMultiplierPct)
- Admin AccountDetail: display RankScore + OriginPoints in Profile card;
new "Award OP" card that credits OP directly to the account balance
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- ModelCache: switch GLTFDocument.append_from_buffer (was append_from_file
which returned ERR_BUSY/43); validate GLB magic bytes; explicit signal
disconnect before queue_free to avoid freed-lambda errors
- ContentCache: add tile model fetch (content.tile_models), disk cache at
user://content/tile_models.json, get_tile_model_url() API
- game_screen: _add_tile now loads tile CDN model via ModelCache when bound
- Server: ContentGetTileModelsHandler (content.tile_models msg), registered
in ServiceRegistration; TileModelDto / GetTileModelsResponse added to
ContentMessages
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
DB / Server:
- Added ResultJson (jsonb, nullable) to GameActionLog entity + EF migration
- Updated SaveStateAsync to accept resultJson (optional, default null)
- All 11 action handlers now serialize GameEngine.ToDto() result into the log
Admin — GameSessionsPage:
- Session IDs are now clickable links → /game/sessions/{id}
- "Abandon All Active" bulk button (previous)
- "Purge All" button (SuperAdmin only, JS confirm) — hard-deletes all sessions
and action logs via cascade
Admin — GameSessionDetailPage (/game/sessions/{id}):
- Session header: status badge, P1/P2 display names (click to copy GUID)
- Info cards: Player 1, Player 2, Created timestamp, Duration/WinCondition
- Action log table: seq#, time, actor name (click to copy GUID), action type
- Expandable Payload (JSON) and Result (JSON) per row
- Actor display names resolved from SorIdentityDbContext
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>