Guard optional values in publication tests
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 6s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 1m57s
Foundation / checks (postgres) (push) Failing after 4m53s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 7m7s
Foundation / checks (tsan) (push) Canceled after 7m8s
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 6s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 1m57s
Foundation / checks (postgres) (push) Failing after 4m53s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 7m7s
Foundation / checks (tsan) (push) Canceled after 7m8s
This commit is contained in:
@@ -7020,3 +7020,5 @@ CI run #308 passed client, deploy, ECS, network and TSan, including the X11 life
|
||||
CI run #309 passed the client, deploy, ECS, network and TSan jobs, and the regular 68-test suite in the main checks job. PostgreSQL's full build then rejected 16 unchecked `std::optional` accesses in `tests/cellular_publication_tests.cpp` under warnings-as-errors. The affected test reads now use `optional::value()` after their existing checks, with committed snapshots stored once where repeated reads were previously unchecked. PostgreSQL tools and server-image/Harbor publication did not start.
|
||||
|
||||
CI run #310 passed client, deploy, ECS and network. The main checks stopped at the formatting gate because three new `CellularBatch::header` initializers were not laid out exactly as clang-format 19 expects. The test source is now formatted with clang-format 19.1.5 and passes its local dry-run check. PostgreSQL analysis was still building when this formatting correction was prepared, so run #310 does not yet validate the optional-access fixes; Harbor publication did not start.
|
||||
|
||||
CI run #311 passed client, deploy, ECS, network and TSan, and compiled the PostgreSQL test target. The PostgreSQL analysis build then still reported 17 unchecked accesses: clang-tidy does not treat the `CHECK(...)` macro or `optional::value()` by itself as proof of engagement. The test now uses a helper with an explicit `has_value()` guard before dereferencing those optionals. This version awaits CI validation; PostgreSQL tools and Harbor publication did not start.
|
||||
|
||||
Reference in New Issue
Block a user