Format cellular publication test updates
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 2m6s
Foundation / checks (tsan) (push) Successful in 8m24s
Foundation / checks (postgres) (push) Failing after 24m28s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 27m19s

This commit is contained in:
dingo
2026-10-11 19:35:39 -04:00
parent 7537250fab
commit 8322f9c855
2 changed files with 14 additions and 12 deletions
+2
View File
@@ -7018,3 +7018,5 @@ CI run #307 passed the format/deploy/ECS/network/TSan gates. The instrumented `n
CI run #308 passed client, deploy, ECS, network and TSan, including the X11 lifecycle and AddressSanitizer client probes. PostgreSQL clang-tidy again rejected `site()` in `apps/evo-world-clone/main.cpp`, this time because `bugprone-suspicious-stringview-data-usage` treats `string_view::data()` on the split coordinate text as potentially unterminated even though `from_chars` receives a bounded range. The parser now passes the split views' begin/end iterators instead. The PostgreSQL tools and server-image/Harbor jobs did not start.
CI run #309 passed the client, deploy, ECS, network and TSan jobs, and the regular 68-test suite in the main checks job. PostgreSQL's full build then rejected 16 unchecked `std::optional` accesses in `tests/cellular_publication_tests.cpp` under warnings-as-errors. The affected test reads now use `optional::value()` after their existing checks, with committed snapshots stored once where repeated reads were previously unchecked. PostgreSQL tools and server-image/Harbor publication did not start.
CI run #310 passed client, deploy, ECS and network. The main checks stopped at the formatting gate because three new `CellularBatch::header` initializers were not laid out exactly as clang-format 19 expects. The test source is now formatted with clang-format 19.1.5 and passes its local dry-run check. PostgreSQL analysis was still building when this formatting correction was prepared, so run #310 does not yet validate the optional-access fixes; Harbor publication did not start.
+12 -12
View File
@@ -114,8 +114,8 @@ void cellular_birth_publication_is_durable() {
CellularBatch batch;
const auto predecessor_digest = sha256(committed.value().manifest);
CHECK(predecessor_digest);
batch.header = {key.world, key.region, 1, committed.value().head.commit,
predecessor_digest.value(), 0, 1};
batch.header = {
key.world, key.region, 1, committed.value().head.commit, predecessor_digest.value(), 0, 1};
CellularTickIntents tick;
tick.births.push_back(reservation);
batch.ticks.push_back(tick);
@@ -218,22 +218,22 @@ void cellular_profile_migration_is_durable_and_recovers_without_a_tick() {
CellularBatch batch;
const auto predecessor_digest = sha256(predecessor.value().manifest);
CHECK(predecessor_digest);
batch.header = {key.world, key.region, 1, predecessor.value().head.commit,
predecessor_digest.value(), 0, 1};
batch.header = {
key.world, key.region, 1, predecessor.value().head.commit, predecessor_digest.value(),
0, 1};
batch.ticks.resize(1);
for (const auto& life : host->state()->lives())
batch.ticks[0].lives.push_back({life.identity.life, {}});
const auto published = host->publish(batch);
CHECK(published && published->committed.head.sequence == 1);
auto migrated = migrate_cellular_profile_to_v2(
*owner, **migration_objects, authority.value(), published->committed, filled<16>(0x51),
build, 5s);
auto migrated =
migrate_cellular_profile_to_v2(*owner, **migration_objects, authority.value(),
published->committed, filled<16>(0x51), build, 5s);
CHECK(migrated && migrated->head.sequence == 2 && migrated->head.end_tick == 1);
CHECK(
retry_cellular_profile_migration(*owner, {key, filled<16>(0x51), migrated->manifest}, 5s));
auto revision_migrated = migrate_cellular_profile_to_v3(*owner, **migration_objects,
authority.value(),
*migrated, filled<16>(0x52), build, 5s);
auto revision_migrated = migrate_cellular_profile_to_v3(
*owner, **migration_objects, authority.value(), *migrated, filled<16>(0x52), build, 5s);
CHECK(revision_migrated && revision_migrated->head.sequence == 3 &&
revision_migrated->head.end_tick == 1);
CHECK(retry_cellular_profile_migration(
@@ -362,8 +362,8 @@ void run_cellular_publication_tests() {
CellularBatch batch;
const auto predecessor_digest = sha256(committed.value().manifest);
CHECK(predecessor_digest);
batch.header = {key.world, key.region, 1, committed.value().head.commit,
predecessor_digest.value(), 0, 2};
batch.header = {
key.world, key.region, 1, committed.value().head.commit, predecessor_digest.value(), 0, 2};
batch.ticks.resize(2);
for (auto& tick : batch.ticks)
tick.lives.push_back({(*opening)->lives()[0].identity.life, {}});