Guard cellular publication test optionals
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 6s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 1m54s
Foundation / checks (checks) (push) Failing after 4m0s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (tsan) (push) Canceled after 6m54s
Foundation / checks (postgres) (push) Canceled after 6m59s
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 6s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 1m54s
Foundation / checks (checks) (push) Failing after 4m0s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (tsan) (push) Canceled after 6m54s
Foundation / checks (postgres) (push) Canceled after 6m59s
This commit is contained in:
@@ -7016,3 +7016,5 @@ CI run #306 passed formatting, deploy selection, ECS, and TSan, and built the Po
|
||||
CI run #307 passed the format/deploy/ECS/network/TSan gates. The instrumented `native_input()` open succeeded, but the next application open in `toolkit_capture()` failed (line 277 in that run), before PostgreSQL analysis completed; Harbor publication did not start. This second open now reports its typed error and SDL initialization state too, so the next run can distinguish an SDL window failure from toolkit initialization.
|
||||
|
||||
CI run #308 passed client, deploy, ECS, network and TSan, including the X11 lifecycle and AddressSanitizer client probes. PostgreSQL clang-tidy again rejected `site()` in `apps/evo-world-clone/main.cpp`, this time because `bugprone-suspicious-stringview-data-usage` treats `string_view::data()` on the split coordinate text as potentially unterminated even though `from_chars` receives a bounded range. The parser now passes the split views' begin/end iterators instead. The PostgreSQL tools and server-image/Harbor jobs did not start.
|
||||
|
||||
CI run #309 passed the client, deploy, ECS, network and TSan jobs, and the regular 68-test suite in the main checks job. PostgreSQL's full build then rejected 16 unchecked `std::optional` accesses in `tests/cellular_publication_tests.cpp` under warnings-as-errors. The affected test reads now use `optional::value()` after their existing checks, with committed snapshots stored once where repeated reads were previously unchecked. PostgreSQL tools and server-image/Harbor publication did not start.
|
||||
|
||||
@@ -98,9 +98,11 @@ void cellular_birth_publication_is_durable() {
|
||||
CHECK(host->step().ready);
|
||||
const auto authority = host->authority();
|
||||
CHECK(authority);
|
||||
const auto committed = host->committed();
|
||||
CHECK(committed);
|
||||
const auto account = filled<16>(0x47);
|
||||
const auto control =
|
||||
claim_account_control(*runtime, key, *authority, account, 1, 1, 20'000ms, 5s);
|
||||
claim_account_control(*runtime, key, authority.value(), account, 1, 1, 20'000ms, 5s);
|
||||
CHECK(control);
|
||||
const auto requested = host->create_primitive_life(account, control->generation, 7);
|
||||
CHECK(requested.result == evo::network::PrimitiveLifeResult::pending &&
|
||||
@@ -110,10 +112,10 @@ void cellular_birth_publication_is_durable() {
|
||||
const auto reservation = host->queued_births().front();
|
||||
|
||||
CellularBatch batch;
|
||||
const auto predecessor_digest = sha256(host->committed()->manifest);
|
||||
const auto predecessor_digest = sha256(committed.value().manifest);
|
||||
CHECK(predecessor_digest);
|
||||
batch.header = {key.world, key.region, 1, host->committed()->head.commit,
|
||||
*predecessor_digest, 0, 1};
|
||||
batch.header = {key.world, key.region, 1, committed.value().head.commit,
|
||||
predecessor_digest.value(), 0, 1};
|
||||
CellularTickIntents tick;
|
||||
tick.births.push_back(reservation);
|
||||
batch.ticks.push_back(tick);
|
||||
@@ -127,10 +129,12 @@ void cellular_birth_publication_is_durable() {
|
||||
CHECK(host_outcome.result == evo::network::PrimitiveLifeResult::born &&
|
||||
host_outcome.life_identity == reservation.identity && host_outcome.commit_sequence == 1);
|
||||
const auto outcome =
|
||||
query_primitive_life(*runtime, key, *authority, account, control->generation, 7, 5s);
|
||||
CHECK(outcome && outcome->has_value() && (*outcome)->published &&
|
||||
(*outcome)->published->identity == reservation.identity &&
|
||||
(*outcome)->published->born == 1);
|
||||
query_primitive_life(*runtime, key, authority.value(), account, control->generation, 7, 5s);
|
||||
CHECK(outcome && outcome.value().has_value());
|
||||
const auto& outcome_value = outcome.value().value();
|
||||
CHECK(outcome_value.published.has_value());
|
||||
CHECK(outcome_value.published.value().identity == reservation.identity &&
|
||||
outcome_value.published.value().born == 1);
|
||||
host->drain();
|
||||
host.reset();
|
||||
|
||||
@@ -208,23 +212,27 @@ void cellular_profile_migration_is_durable_and_recovers_without_a_tick() {
|
||||
const auto authority = host->authority();
|
||||
CHECK(authority);
|
||||
const auto predecessor = host->committed();
|
||||
CHECK(predecessor && predecessor->head.sequence == 0);
|
||||
CHECK(predecessor);
|
||||
CHECK(predecessor.value().head.sequence == 0);
|
||||
|
||||
CellularBatch batch;
|
||||
const auto predecessor_digest = sha256(predecessor->manifest);
|
||||
const auto predecessor_digest = sha256(predecessor.value().manifest);
|
||||
CHECK(predecessor_digest);
|
||||
batch.header = {key.world, key.region, 1, predecessor->head.commit, *predecessor_digest, 0, 1};
|
||||
batch.header = {key.world, key.region, 1, predecessor.value().head.commit,
|
||||
predecessor_digest.value(), 0, 1};
|
||||
batch.ticks.resize(1);
|
||||
for (const auto& life : host->state()->lives())
|
||||
batch.ticks[0].lives.push_back({life.identity.life, {}});
|
||||
const auto published = host->publish(batch);
|
||||
CHECK(published && published->committed.head.sequence == 1);
|
||||
auto migrated = migrate_cellular_profile_to_v2(
|
||||
*owner, **migration_objects, *authority, published->committed, filled<16>(0x51), build, 5s);
|
||||
*owner, **migration_objects, authority.value(), published->committed, filled<16>(0x51),
|
||||
build, 5s);
|
||||
CHECK(migrated && migrated->head.sequence == 2 && migrated->head.end_tick == 1);
|
||||
CHECK(
|
||||
retry_cellular_profile_migration(*owner, {key, filled<16>(0x51), migrated->manifest}, 5s));
|
||||
auto revision_migrated = migrate_cellular_profile_to_v3(*owner, **migration_objects, *authority,
|
||||
auto revision_migrated = migrate_cellular_profile_to_v3(*owner, **migration_objects,
|
||||
authority.value(),
|
||||
*migrated, filled<16>(0x52), build, 5s);
|
||||
CHECK(revision_migrated && revision_migrated->head.sequence == 3 &&
|
||||
revision_migrated->head.end_tick == 1);
|
||||
@@ -244,8 +252,10 @@ void cellular_profile_migration_is_durable_and_recovers_without_a_tick() {
|
||||
auto restarted_made = CellularRegionHost::create(config, connect, std::move(*recovery_objects));
|
||||
CHECK(restarted_made);
|
||||
auto restarted = std::move(*restarted_made);
|
||||
CHECK(restarted->step().ready && restarted->committed()->head.sequence == 3 &&
|
||||
restarted->committed()->head.end_tick == 1 && restarted->state()->tick() == 1 &&
|
||||
const auto restarted_committed = restarted->committed();
|
||||
CHECK(restarted_committed);
|
||||
CHECK(restarted->step().ready && restarted_committed.value().head.sequence == 3 &&
|
||||
restarted_committed.value().head.end_tick == 1 && restarted->state()->tick() == 1 &&
|
||||
restarted->state()->format_version() == cellular_lives_revision_format &&
|
||||
restarted->state()->snapshot() == *target_payload);
|
||||
restarted->drain();
|
||||
@@ -347,11 +357,13 @@ void run_cellular_publication_tests() {
|
||||
CHECK(made_host);
|
||||
auto host = std::move(*made_host);
|
||||
CHECK(host->step().ready);
|
||||
const auto committed = host->committed();
|
||||
CHECK(committed);
|
||||
CellularBatch batch;
|
||||
const auto predecessor_digest = sha256(host->committed()->manifest);
|
||||
const auto predecessor_digest = sha256(committed.value().manifest);
|
||||
CHECK(predecessor_digest);
|
||||
batch.header = {key.world, key.region, 1, host->committed()->head.commit,
|
||||
*predecessor_digest, 0, 2};
|
||||
batch.header = {key.world, key.region, 1, committed.value().head.commit,
|
||||
predecessor_digest.value(), 0, 2};
|
||||
batch.ticks.resize(2);
|
||||
for (auto& tick : batch.ticks)
|
||||
tick.lives.push_back({(*opening)->lives()[0].identity.life, {}});
|
||||
@@ -377,8 +389,10 @@ void run_cellular_publication_tests() {
|
||||
CellularRegionHost::create(config, connect, std::move(*restarted_objects));
|
||||
CHECK(made_restarted);
|
||||
auto restarted = std::move(*made_restarted);
|
||||
const auto restarted_committed = restarted->committed();
|
||||
CHECK(restarted_committed);
|
||||
CHECK(restarted->step().ready && restarted->state()->tick() == 2 &&
|
||||
restarted->state()->snapshot() == (**replay).snapshot() &&
|
||||
restarted->committed()->head.sequence == 1);
|
||||
restarted_committed.value().head.sequence == 1);
|
||||
restarted->drain();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user