Parse clone sites through bounded views
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (ecs) (push) Successful in 1m58s
Foundation / checks (tsan) (push) Successful in 8m51s
Foundation / checks (client) (push) Successful in 13m33s
Foundation / checks (network) (push) Successful in 15m10s
Foundation / checks (postgres) (push) Failing after 25m19s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 28m29s
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (ecs) (push) Successful in 1m58s
Foundation / checks (tsan) (push) Successful in 8m51s
Foundation / checks (client) (push) Successful in 13m33s
Foundation / checks (network) (push) Successful in 15m10s
Foundation / checks (postgres) (push) Failing after 25m19s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 28m29s
This commit is contained in:
@@ -121,12 +121,13 @@ std::optional<server::SpawnSite> site(std::string_view text) {
|
||||
const auto comma = text.find(',');
|
||||
if (comma == std::string_view::npos || text.find(',', comma + 1) != std::string_view::npos)
|
||||
return std::nullopt;
|
||||
const auto x_text = text.substr(0, comma);
|
||||
const auto y_text = text.substr(comma + 1);
|
||||
std::int32_t x{}, y{};
|
||||
const auto [x_end, x_error] = std::from_chars(text.data(), text.data() + comma, x);
|
||||
const auto [y_end, y_error] =
|
||||
std::from_chars(text.data() + comma + 1, text.data() + text.size(), y);
|
||||
if (x_error != std::errc{} || x_end != text.data() + comma || y_error != std::errc{} ||
|
||||
y_end != text.data() + text.size())
|
||||
const auto [x_end, x_error] = std::from_chars(x_text.begin(), x_text.end(), x);
|
||||
const auto [y_end, y_error] = std::from_chars(y_text.begin(), y_text.end(), y);
|
||||
if (x_error != std::errc{} || x_end != x_text.end() || y_error != std::errc{} ||
|
||||
y_end != y_text.end())
|
||||
return std::nullopt;
|
||||
return server::SpawnSite{x, y};
|
||||
}
|
||||
|
||||
@@ -7014,3 +7014,5 @@ CI run #305 passed formatting and most independent gates, but PostgreSQL clang-t
|
||||
CI run #306 passed formatting, deploy selection, ECS, and TSan, and built the PostgreSQL test targets. Its client lifecycle probe failed at `native_input()` while opening the SDL application (line 174); the test reported only the source line and an empty SDL error, so the startup error was not identifiable. It has been updated to report the typed application error and SDL initialization state. PostgreSQL static analysis was still running when this follow-up was prepared; Harbor publication did not start.
|
||||
|
||||
CI run #307 passed the format/deploy/ECS/network/TSan gates. The instrumented `native_input()` open succeeded, but the next application open in `toolkit_capture()` failed (line 277 in that run), before PostgreSQL analysis completed; Harbor publication did not start. This second open now reports its typed error and SDL initialization state too, so the next run can distinguish an SDL window failure from toolkit initialization.
|
||||
|
||||
CI run #308 passed client, deploy, ECS, network and TSan, including the X11 lifecycle and AddressSanitizer client probes. PostgreSQL clang-tidy again rejected `site()` in `apps/evo-world-clone/main.cpp`, this time because `bugprone-suspicious-stringview-data-usage` treats `string_view::data()` on the split coordinate text as potentially unterminated even though `from_chars` receives a bounded range. The parser now passes the split views' begin/end iterators instead. The PostgreSQL tools and server-image/Harbor jobs did not start.
|
||||
|
||||
Reference in New Issue
Block a user