Report toolkit client startup failures
Foundation / checks (deploy) (push) Successful in 6s
Foundation / checks (network) (push) Successful in 5s
Foundation / checks (ecs) (push) Successful in 2m1s
Foundation / checks (tsan) (push) Successful in 9m9s
Foundation / checks (client) (push) Successful in 13m13s
Foundation / checks (postgres) (push) Failing after 23m17s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 25m2s

This commit is contained in:
dingo
2026-10-11 18:35:24 -04:00
parent 082c7f9c33
commit 11bff3169e
2 changed files with 7 additions and 1 deletions
+2
View File
@@ -7012,3 +7012,5 @@ CI run #304 rejected both wrapped layouts of the SQLSTATE expression at the form
CI run #305 passed formatting and most independent gates, but PostgreSQL clang-tidy rejected `site()` in `apps/evo-world-clone/main.cpp`: `string_view::data()` may be null for an empty view passed to `from_chars`. The parser now rejects an empty site argument before accessing its data. The dependent PostgreSQL tools and server-image/Harbor publication jobs did not run; CI must validate the guard and complete publication.
CI run #306 passed formatting, deploy selection, ECS, and TSan, and built the PostgreSQL test targets. Its client lifecycle probe failed at `native_input()` while opening the SDL application (line 174); the test reported only the source line and an empty SDL error, so the startup error was not identifiable. It has been updated to report the typed application error and SDL initialization state. PostgreSQL static analysis was still running when this follow-up was prepared; Harbor publication did not start.
CI run #307 passed the format/deploy/ECS/network/TSan gates. The instrumented `native_input()` open succeeded, but the next application open in `toolkit_capture()` failed (line 277 in that run), before PostgreSQL analysis completed; Harbor publication did not start. This second open now reports its typed error and SDL initialization state too, so the next run can distinguish an SDL window failure from toolkit initialization.
+5 -1
View File
@@ -274,7 +274,11 @@ void native_input() {
void toolkit_capture() {
const auto frame = fixture();
auto result = Application::open({320, 240, false, "software"});
CHECK(result);
if (!result)
throw std::runtime_error("toolkit-capture open failed error=" +
std::to_string(static_cast<unsigned>(result.error())) +
" SDL_WasInit=" + std::to_string(SDL_WasInit(0)) +
" SDL=" + SDL_GetError());
auto app = std::move(result.value());
CHECK(app->poll_events());
const auto id = SDL_GetWindowID(window());