Avoid unchecked optional in mutation reservation load
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (ecs) (push) Successful in 1m56s
Foundation / checks (client) (push) Successful in 13m45s
Foundation / checks (network) (push) Successful in 14m55s
Foundation / checks (tsan) (push) Successful in 8m31s
Foundation / checks (postgres) (push) Failing after 19m55s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (checks) (push) Canceled after 35m38s

This commit is contained in:
dingo
2026-10-11 12:33:03 -04:00
parent 6a99d31b6e
commit 16d8a9d098
2 changed files with 9 additions and 2 deletions
+7
View File
@@ -6920,3 +6920,10 @@ access in the cellular profile-migration recovery check at
optional migration record through `value_or` and validates the copy after
preserving the missing-record history failure. PostgreSQL failed on this
diagnostic, so the image and Harbor jobs remained blocked.
CI run #291 confirmed the migration-recovery repair and found another unchecked
optional in the PostgreSQL reservation-row decoder at
`src/persistence/region_lease_store.cpp:1322`. The decoder now passes a safe
empty-string default to the hex parser; absent or malformed input still fails
the existing validation path. The PostgreSQL job failed on this diagnostic, so
the dependent server-image and Harbor jobs did not start.
+2 -2
View File
@@ -1318,8 +1318,8 @@ load_pending_cellular_mutations(Postgres& db, RegionKey key, const LeaseGrant& l
const auto generation = parse_integer<std::uint64_t>(row[2]);
const auto target_tick = parse_integer<std::uint64_t>(row[3]);
const auto successor = parse_integer<std::uint64_t>(row[4]);
const auto input =
row[5] ? unhex<cellular_mutation_reservation_input_bytes>(*row[5]) : std::nullopt;
const auto input_hex = row[5].value_or(std::string{});
const auto input = unhex<cellular_mutation_reservation_input_bytes>(input_hex);
if (!account || *account == Uuid{} || !action || *action == 0 || !generation ||
*generation == 0 || !target_tick || *target_tick == 0 || !successor ||
*successor == 0 || !input || little(*input, 0, 8) != *target_tick ||