Fix run 252 static and session checks
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (ecs) (push) Successful in 1m52s
Foundation / checks (postgres) (push) Canceled after 0s
Foundation / checks (tsan) (push) Canceled after 0s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (client) (push) Canceled after 11m14s
Foundation / checks (network) (push) Canceled after 9m19s
Foundation / checks (checks) (push) Canceled after 11m19s

This commit is contained in:
dingo
2026-10-11 04:40:44 -04:00
parent 8d0a6f0fa4
commit 3548f2eacf
4 changed files with 13 additions and 3 deletions
+10
View File
@@ -6753,3 +6753,13 @@ executables, and the negative test uses unsupported version 10.
Run 250's network test job failed on the stale expectation; the two omitted
tests were not run because their executables were absent. Follow-up CI is
required to confirm the corrected gate.
Run 252 exercised the repaired network preset, then found three compiler gates
outside the earlier test: clang-tidy reported an optional dereference in the
cellular-step test and a signed-width multiplication in the cellular-perception
protocol assertion; GCC 14 reported a missing diagnostics-field initializer in
the session server's cleared-perception record. The test accesses now use an
explicit optional value accessor after the checked guard, the size expression
widens before multiplication, and the cleared record initializes all fields.
Windows Debug owner/step tests, protocol test, session-server target build and
format check passed locally. Full CI follow-up is pending.
+1 -1
View File
@@ -902,7 +902,7 @@ void RegionSessions::clear_cellular_perceptions(std::uint64_t tick) {
if (tick == 0)
return;
auto& m = *impl_;
const network::CellularPerception cleared{tick, 0, {}};
const network::CellularPerception cleared{tick, 0, {}, {}};
for (const auto& c : m.connections)
if (c.state == Impl::State::established &&
(c.protocol_version == network::session_protocol_v8 ||
+1 -1
View File
@@ -120,7 +120,7 @@ void v8_perception_is_bounded_and_canonical() {
const CellularPerception perception{
19, 42, {{1'000, 2'000, 3, {4, 5, 6, 7}}, {1'000, 3'000, 8, {9, 10, 11, 12}}}};
const auto bytes = encode_session(SessionMessage{perception});
CHECK(!bytes.empty() && bytes.size() == session_header_bytes + 18 + 2 * 48);
CHECK(!bytes.empty() && bytes.size() == session_header_bytes + 18 + std::size_t{2} * 48);
std::uint16_t version{};
const auto decoded = decode_session(bytes, &version);
CHECK(decoded && version == session_protocol_v8);
+1 -1
View File
@@ -50,7 +50,7 @@ void maintenance_motion_and_intake_conserve_one_tick() {
CHECK(step->reserve_after == Inventory{{195}, {{{5}, {2}, {1}, {0}}}});
if (step->intake_status != CellularIntakeStatus::acquired || !step->intake)
throw std::runtime_error("cellular step intake missing");
const auto& intake = *step->intake;
const auto& intake = step->intake.value();
CHECK(intake.transfer.patch_after == Inventory{{950}, {{{15}, {8}, {4}, {2}}}});
CHECK(reserve.energy.value == 200 && heat.energy.value == 0);
CHECK(map->patches()[0].stock == Inventory{{1'000}, {{{20}, {10}, {5}, {2}}}});