Check expected results in publication tests
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 1m58s
Foundation / checks (tsan) (push) Successful in 8m40s
Foundation / checks (postgres) (push) Failing after 31m51s
Foundation / checks (checks) (push) Successful in 37m1s
Foundation / postgres-tools (push) Skipped
Foundation / server-image (push) Skipped
Foundation / image (push) Skipped

This commit is contained in:
dingo
2026-10-11 20:10:04 -04:00
parent 0ff24a97e6
commit 8b2b56a612
2 changed files with 7 additions and 0 deletions
+2
View File
@@ -7022,3 +7022,5 @@ CI run #309 passed the client, deploy, ECS, network and TSan jobs, and the regul
CI run #310 passed client, deploy, ECS and network. The main checks stopped at the formatting gate because three new `CellularBatch::header` initializers were not laid out exactly as clang-format 19 expects. The test source is now formatted with clang-format 19.1.5 and passes its local dry-run check. PostgreSQL analysis was still building when this formatting correction was prepared, so run #310 does not yet validate the optional-access fixes; Harbor publication did not start.
CI run #311 passed client, deploy, ECS, network and TSan, and compiled the PostgreSQL test target. The PostgreSQL analysis build then still reported 17 unchecked accesses: clang-tidy does not treat the `CHECK(...)` macro or `optional::value()` by itself as proof of engagement. The test now uses a helper with an explicit `has_value()` guard before dereferencing those optionals. This version awaits CI validation; PostgreSQL tools and Harbor publication did not start.
CI run #312 passed client, deploy, ECS and network, but the PostgreSQL-enabled test build found that the new `checked_value` helper only accepted `std::optional`, while the SHA-256 helper returns `std::expected`. The test now provides the same explicit engagement check for `std::expected`; run #312 did not reach PostgreSQL tools or server-image/Harbor publication.
+5
View File
@@ -25,6 +25,11 @@ template <typename T> const T& checked_value(const std::optional<T>& value) {
throw std::runtime_error("cellular publication test expected an optional value");
return *value;
}
template <typename T, typename E> const T& checked_value(const std::expected<T, E>& value) {
if (!value.has_value())
throw std::runtime_error("cellular publication test expected a successful result");
return *value;
}
std::string env(const char* name) {
const auto* value = std::getenv(name);
if (!value)