Allow winhttp.dll in the Windows client package
Foundation / checks (checks) (push) Successful in 5s
Foundation / checks (client) (push) Successful in 4s
Foundation / checks (ecs) (push) Successful in 4s
Foundation / checks (network) (push) Successful in 4s
Foundation / checks (postgres) (push) Successful in 5s
Foundation / checks (tsan) (push) Successful in 4s
Foundation / checks (deploy) (push) Successful in 4m25s
Foundation / postgres-tools (push) Successful in 5s
Foundation / image (push) Successful in 5s
Foundation / server-image (push) Successful in 5s

The ADR-0131 browser sign-in and grant broker requests link winhttp.dll, a Windows
system DLL, but the package's import allowlist predates them, so package-windows.ps1
refused evo-client.exe ("imports winhttp.dll, which is not an allowed system DLL").

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
dingo
2026-10-16 21:40:54 -04:00
co-authored by Claude Opus 5.5
parent 7180182c2f
commit a3af969424
2 changed files with 4 additions and 3 deletions
@@ -12,7 +12,7 @@ spec:
env:
- {name: REGION_SESSION, value: "dev"}
- {name: REGION_SESSION_LISTEN, value: "0.0.0.0:7400"}
- {name: REGION_SESSION_WINDOW, value: "dev-20261016T201912-30463:1792192752"}
- {name: REGION_SESSION_WINDOW, value: "dev-20261017T014054-10359:1792212054"}
- {name: REGION_M10_MAX_GRANT_LIFETIME, value: "14400"}
ports:
# QUIC (ADR-0090): UDP only; nothing listens on TCP 7400.
+3 -2
View File
@@ -27,12 +27,13 @@ $script:PackageFiles = @(
)
# Imports allowed for the executables: Windows system DLLs and the bundled SDL3.dll and
# msquic.dll (M10.5c). The C/C++ runtime is static (no MSVCP/VCRUNTIME/api-ms-win-crt/
# ucrtbase), in msquic.dll too.
# ucrtbase), in msquic.dll too. winhttp.dll carries the Keycloak sign-in and grant broker
# requests (ADR-0131).
$script:AllowedImports = @(
'advapi32.dll', 'bcrypt.dll', 'crypt32.dll', 'gdi32.dll', 'imm32.dll', 'iphlpapi.dll',
'kernel32.dll', 'msquic.dll', 'ncrypt.dll', 'ntdll.dll', 'ole32.dll', 'oleaut32.dll',
'sdl3.dll', 'setupapi.dll', 'shell32.dll', 'user32.dll', 'version.dll', 'winmm.dll',
'ws2_32.dll'
'winhttp.dll', 'ws2_32.dll'
)
# Every shipped image whose imports are checked.
$script:PackageImages = @('evo-client.exe', 'SDL3.dll', 'msquic.dll')