- Status label: connect Network.connected so "Connecting…" clears once the
WebSocket opens (previously the label stuck forever with no session)
- Remember Me: apply font_color override so the checkbox text is visible
- Register errors: map ASP.NET Identity password-policy error codes
(PasswordTooShort, PasswordRequiresUpper/Lower/NonAlphanumeric/Digit) to
user-friendly strings; old WEAK_PASSWORD kept as alias
- Chat poll: guard _on_message_poll_tick with Auth.user_id check so the timer
cannot send chat.get_messages as the first message on a fresh connection
when the user is not yet authenticated (caused by logout not stopping the
timer, leaving it running into the next reconnect cycle)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
_highlight_ability_targets was ignoring the target selector's filters array
entirely — it showed all ownership-matched units as clickable regardless of
spatial constraints. The server correctly rejected out-of-range selections
(after the previous fix) but the UI still offered them.
Added _unit_passes_filters() and _tile_passes_filters() which evaluate the
withinrange and isadjacenttosource filters using Manhattan distance from the
ability source unit before adding a tile highlight. Other filters (HasFlag,
AffinityMatches, etc.) are left as pass-through for now since they didn't
affect visibility in any reported case.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- AbilitySystem: implement WithinRangeFilter (Manhattan distance min/max) and
IsAdjacentToSourceFilter in FilterMatches — both were falling through to
_ => true, so range constraints on targeting were silently ignored
- Program.cs: add GET /cdn/{**path} proxy endpoint with
Access-Control-Allow-Origin: * so browser web clients can fetch GLB models
(Ceph RadosGW / cdn.aeternalisgames.com has no CORS headers)
- ModelCache.gd: on web export, rewrite cdn.aeternalisgames.com URLs to go
through hub.aeternalisgames.com/cdn proxy; disk/memory cache still keyed
on the original CDN URL for consistency across platforms
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
BuildCandidates only added p.Field to the candidate pool for
Scope=Battlefield, leaving p.ArchSpirit (stored as a separate
PlayerState property) out. A Unit-typed ability targeting the
opponent's ArchSpirit would match zero candidates → INSUFFICIENT_TARGETS.
Also include p.ArchSpirit in the AnyZone pool for consistency.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Panel now appears to the right of the clicked spirit by projecting
its 3D world position to screen space via Camera3D.unproject_position,
with viewport-edge clamping so it never goes off-screen
- Removed ScrollContainer (height=0 caused buttons to be invisible);
replaced with plain VBoxContainer — panel auto-sizes to content
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Server serialises AbilityDefinition with PascalCase property names
(Type, Actions, Target, Scope, Ownership, Count, All…). The client
was checking for lowercase keys (\"type\", \"actions\", etc.) so
ab.get(\"type\") always returned null, actives stayed empty, and the
panel was silently skipped.
Added _normalize_keys() which recursively lowercases all Dictionary
keys after JSON.parse_string(), making every subsequent lookup
case-insensitive without needing dual-key fallbacks throughout.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Ability panel now starts a per-action targeting flow instead of
immediately firing the ability
- Board abilities: blue tile highlights for unit/tile targets; click
to collect AbilityTarget and advance to the next action
- Player/zone abilities: left-side player panel with player name
buttons; zone (Hand/Deck/Discard) sub-buttons appear for zone-scoped
abilities
- Re-clicking a selected spirit toggles the ability panel open/closed
- Auto-skips actions whose ownership is Self/ExactSelf/Random or whose
count.all = true (server resolves those without player input)
- Game.send_activate_ability now accepts an optional targets array
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
[JsonDerivedType] alone (without [JsonPolymorphic]) is sufficient in .NET 8 to
activate the built-in PolymorphicTypeResolver, which then throws
NotSupportedException because our custom converter does not support metadata
reads/writes.
Introduce PolyTypeAttribute — a plain internal attribute unknown to the
framework — and replace all [JsonDerivedType] usages on Effect, Condition,
TriggerEvent, and Filter with [PolyType]. PolymorphicAbilityConverter<T> reads
[PolyType] via reflection to build its type map; the framework ignores it entirely.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Having both [JsonPolymorphic] on the class AND a custom JsonConverter<T> in options
causes NotSupportedException: the built-in polymorphic resolver tries to configure
alongside the custom converter but requires it to support metadata reads/writes.
Our custom PolymorphicAbilityConverter<T> takes full ownership of polymorphic
dispatch, so [JsonPolymorphic] is redundant. The [JsonDerivedType] attributes
remain — our converter reads them via reflection for the type map; the framework
ignores them without [JsonPolymorphic] present.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Refactor EffectPolymorphicConverter into a generic PolymorphicAbilityConverter<T>
base class, add concrete converters for all four abstract ability model types:
Effect, Condition, TriggerEvent, and Filter — all share the same abstract +
[JsonPolymorphic] pattern and the same ordering constraint from the admin builder.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
[JsonPolymorphic] on an abstract base class requires $type to appear first in
the JSON object. Card abilities authored in the admin tool don't guarantee this
ordering (e.g. {"N":1,"$type":"DrawCards","Player":"Owner"}), causing a
NotSupportedException at ParseAbilities time.
Add EffectPolymorphicConverter which overrides CanConvert to intercept only
typeof(Effect) (not concrete derived types). It buffers the full JSON object,
finds $type at any position, looks up the concrete type from the [JsonDerivedType]
attribute map, then deserializes via the default converter. Because CanConvert
returns false for concrete types, there is no infinite recursion even for nested
Effect[] (e.g. ApplyOnEventEffect.Effects).
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
For WaitingForOpponent/Started, state always arrives via game.state_update push
not via the ack payload — calling _apply_state_from_payload on the ack was
producing a confusing warning with no real effect. Replace with a match that
only fetches state for AlreadyStarted.
Also add game.session_abandoned push handler: emits Game.session_abandoned
signal (new) and game_screen connects to it to navigate back to MainScreen,
so clients stuck on the loading screen after a server restart recover cleanly.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Both players navigate to the game screen at the same time after match_found
and both send game.ready concurrently. Without row-level locking, each request
reads the other player's ready flag as false before the other's SaveChanges
commits, so neither handler ever sees both flags set — both return
WaitingForOpponent and the session stays Initializing forever.
Fix: wrap GameReadyHandler in an explicit transaction with SELECT … FOR UPDATE,
matching the same locking pattern already used by LoadActiveSessionAsync for
active-game mutations. The second request now blocks until the first commits,
then reads the updated ready flag and proceeds to initialize.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
MatchmakerService is registered before GameStartupCleanupService in
Program.cs. BackgroundService.StartAsync fires ExecuteAsync on a
background thread and returns immediately, so the matchmaker's first
tick runs concurrently with the cleanup's StartAsync. If players were
already in the queue when the process restarted, the matchmaker creates
a fresh Initializing session within the first milliseconds of startup —
and the cleanup's ToListAsync would include it, abandoning a brand-new
session before game.ready could be sent.
Adding a 60-second staleness threshold: sessions younger than 60 s are
left alone; only genuinely stale sessions (from the previous process)
are abandoned. A legitimate game.ready exchange completes in < 10 s, so
60 s is a safe lower bound.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
When SOR.Game is redeployed, sessions in Initializing status are
unreachable — clients already sent game.ready to the old process and
won't retry. GameStartupCleanupService runs once at startup, marks all
Initializing sessions as Abandoned (WinCondition = "server_restart"),
and pushes game.session_abandoned to both players so clients can return
to the main menu instead of hanging on the loading screen.
Also fix MatchmakerService to include WinnerOpReward, LoserOpReward,
and RankDiffOpMultiplierPct in the rule snapshot so FinalizeGameAsync
picks up the correct OP rewards from the snapshot.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- ChatChannel: add ArchivedAt (nullable DateTimeOffset)
- ChatChannelMembership.EndMatchMembershipsAsync: set channel.ArchivedAt
so match channels are archived when games end
- GameHandlerBase.FinalizeGameAsync: add IEventBus param; compute
OriginPoints rewards scaled by rank diff; publish GameEndedEvent so
ChatLifecycleHostedService triggers archival
- GameRuleSet: add WinnerOpReward (50), LoserOpReward (10),
RankDiffOpMultiplierPct (0) with NOT NULL + defaults
- GameMessages.GameOverPush: add WinnerOpDelta / LoserOpDelta fields
- GameConcedeHandler + GameAttackHandler: inject IEventBus, pass to
FinalizeGameAsync
- Migrations: 20260309200000_AddArchivedAtToChatChannel (ChatDbContext),
20260309210000_AddOpRewardFields (GameDbContext)
- Admin GameSessionsPage: inject ChatDbContext; purge Match channels
before deleting sessions in PurgeAllAsync
- Admin RankedRulesPage: new "Origin Points Rewards" card with three
number inputs (WinnerOpReward, LoserOpReward, RankDiffOpMultiplierPct)
- Admin AccountDetail: display RankScore + OriginPoints in Profile card;
new "Award OP" card that credits OP directly to the account balance
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Adds _fit_model_to_tile() + _model_local_aabb() helpers. After a tile
model loads, its AABB is computed from all descendant VisualInstance3D
nodes in the model's local space. The model is then uniformly scaled so
its largest XZ dimension = 0.98 units, and repositioned so it is
centred on XZ with its bottom at y = 0 of the tile body.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
_update_tile_affinity previously only repainted the placeholder material.
Now extracts model loading into _try_load_tile_model() which is called
both at initial board build (_add_tile) and on every affinity change
(_update_tile_affinity). Handles model swapping correctly — removes all
non-collision children before adding the new model so Lake→Hill transitions
don't stack meshes.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- ModelCache._download: log result enum, HTTP code, body size,
Content-Type header, and first 16 bytes for every download — enough
to diagnose why Godot receives non-GLB data despite CDN serving valid GLB
- Moved disk-cache write to AFTER a successful parse so corrupt bytes
are never written; disk cache read now deletes + re-downloads on bad parse
- game_screen: replace raw `body` lambda captures with weakref to
eliminate "Lambda capture freed" noise (behavior unchanged)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- ModelCache: switch GLTFDocument.append_from_buffer (was append_from_file
which returned ERR_BUSY/43); validate GLB magic bytes; explicit signal
disconnect before queue_free to avoid freed-lambda errors
- ContentCache: add tile model fetch (content.tile_models), disk cache at
user://content/tile_models.json, get_tile_model_url() API
- game_screen: _add_tile now loads tile CDN model via ModelCache when bound
- Server: ContentGetTileModelsHandler (content.tile_models msg), registered
in ServiceRegistration; TileModelDto / GetTileModelsResponse added to
ContentMessages
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Client:
- Added ModelCache autoload (autoloads/ModelCache.gd)
- Downloads .glb files from CDN via HTTPRequest
- Disk cache: user://remote_model_cache/<sha256>.glb
- Memory cache: PackedScene per URL for instant re-instantiation
- Concurrent requests for same URL queue and share one download
- Loads via GLTFDocument.append_from_file + generate_scene
- game_screen.gd: _add_unit_mesh now looks up cardDefinitionId
→ ContentCache.get_definition() → finds Model3D asset URL
→ calls ModelCache.load_model() to async replace placeholder geometry
- Placeholder (sphere/cylinder/box) shown immediately
- Real model swaps in on download completion
- Guards against body being freed before model arrives
- Added _unit_bodies dict for O(1) body lookup
- project.godot: registered ModelCache autoload
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
DB / Server:
- Added ResultJson (jsonb, nullable) to GameActionLog entity + EF migration
- Updated SaveStateAsync to accept resultJson (optional, default null)
- All 11 action handlers now serialize GameEngine.ToDto() result into the log
Admin — GameSessionsPage:
- Session IDs are now clickable links → /game/sessions/{id}
- "Abandon All Active" bulk button (previous)
- "Purge All" button (SuperAdmin only, JS confirm) — hard-deletes all sessions
and action logs via cascade
Admin — GameSessionDetailPage (/game/sessions/{id}):
- Session header: status badge, P1/P2 display names (click to copy GUID)
- Info cards: Player 1, Player 2, Created timestamp, Duration/WinCondition
- Action log table: seq#, time, actor name (click to copy GUID), action type
- Expandable Payload (JSON) and Result (JSON) per row
- Actor display names resolved from SorIdentityDbContext
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Client (game_screen.gd):
- Scroll wheel no longer zooms camera when mouse is over the hand panel
- Clicking a friendly unit smoothly tweens camera pivot to that unit
(EASE_OUT CUBIC, 0.4s) — respects Settings.camera_follow_unit toggle
- Chat overlay instantiated from game screen and removed on exit
Client (Settings.gd + SettingsScreen):
- Added camera_follow_unit bool (default: on) to gameplay settings section
- Persisted to user://settings.cfg under [gameplay]
- Toggle visible in Settings screen under new GAMEPLAY section
Server Admin (MatchmakingQueuePage):
- "Clear History" button deletes all non-Searching matchmaking entries
Server Admin (GameSessionsPage):
- Per-row "Abandon" button for Active/Initializing sessions
- "Abandon All Active" bulk button marks all live sessions as Abandoned
with EndedAt=now and WinCondition="admin"
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Removes the broken CardDetailPopup overlay machinery entirely.
Double-clicking a battlefield unit now populates and shows the existing
ContextPopup with name/type/affinity header, HP/DEF/ATK/MP stats row,
and ability list (name + description bullets).
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
The full-rect Control wrapper had default MOUSE_FILTER_STOP, eating
all clicks across the entire screen. Set MOUSE_FILTER_IGNORE so input
passes through to the 3D scene and HUD beneath it.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
CenterContainer/ScrollContainer require a proper Control parent to
compute sizes. Adding CardDetailPopup directly to a CanvasLayer broke
the nested container layout chain, causing zero-height Panel (invisible
content despite the grey overlay showing correctly).
Fix: spawn a dedicated CanvasLayer (layer 20, above HUD at layer 10)
containing a full-rect Control anchor, then parent the popup to that
Control. This restores proper anchor→Control→Container sizing.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
theme_override_constants["key"] and theme_override_font_sizes["key"]
throw on nodes not yet in the scene tree. Replaced with the proper
add_theme_constant_override() / add_theme_font_size_override() calls.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
`ExactSelf` was accepted by the admin builder dropdown but crashed on
deserialization because the TargetOwnership enum was missing the value.
- Added `ExactSelf` to `TargetOwnership` enum in Action.cs
- BuildCandidates treats ExactSelf like Self/Owner (actor's player pool)
- ResolveTargets post-filters to ctx.Source.InstanceId when ExactSelf
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
TargetOwnerships: add "ExactSelf" so action target selectors can restrict to
the specific unit instance that owns the ability (rather than any allied unit).
Target Filter dropdown (new): exposes the TargetSelector.Filters[] field that
previously had no UI. Supports no-param filter types:
• (none)
• IsSelf — any unit with the same card definition
• IsExactSelf — only this specific instance (InstanceId match)
• IsAdjacentToSource
Filter compiles to Target.Filters[0] in the JSON and round-trips correctly
when loading existing ability JSON back into the builder.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Client (game_screen.gd):
- Fix crash when clicking a unit with null abilitiesJson: server sends the key
with a null value, so dict.get(key,default) returns null — guard both uses
(_show_ability_panel and _on_hold_timer_fired) with explicit null check.
- Add double-click on battlefield units to open a full CardDetailPopup showing
name, affinity, stats, and ability descriptions. Popup is instantiated once
in _ready() and reused; aliases movementPoints/abilities keys as expected.
Server (Filters.cs / AbilitySystem.cs):
- IsSelf filter now matches by CardDefinitionId (definition-level: any copy of
the same card). This is the appropriate semantic for "self" as a type scope.
- IsExactSelf filter added: matches by InstanceId (instance-level: only this
specific unit on the battlefield). Use this to prevent duplicate-instance
trigger bleed where two copies of a card both fire when only one acted.
- TriggerMatches now accepts the evaluating FieldCard and forwards its
InstanceId to Own() for all ownership checks.
- Own() gains "ExactSelf" scope: fires only when occ.Data.SourceId matches the
evaluating unit's InstanceId — eliminating the definition-level bleed bug.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Root cause: _rebuild_hand used queue_free() alone, which keeps nodes in the
GUI tree (and receiving input events) until end-of-frame. When two state
updates arrive in the same frame, stale and live CardWidget instances overlap
at the same screen position — both emit card_pressed → _on_hand_card_clicked
fires twice per physical click, alternating select/deselect.
Fix 1 (root cause): _rebuild_hand now calls remove_child(c) before queue_free(c),
so the old widget is immediately detached from the HBoxContainer and can no
longer receive GUI input.
Fix 2 (defensive): _on_hand_card_clicked deduplicates calls within the same
engine frame for the same card instance using Engine.get_process_frames().
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Setting widget.z_index = 20 synchronously while a mouse button is held causes
Godot 4 to re-evaluate GUI focus and deliver a synthetic second pressed=true
event to the widget. This fired card_pressed a second time in the same frame,
making _on_hand_card_clicked see the card already selected → immediate deselect.
Fix: move tween creation and z_index assignment into a new _tween_hand_card()
helper, called via call_deferred() so it runs after the current input event is
fully processed (mouse button already released by then).
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Godot 4 fires two separate pressed=true InputEventMouseButton events for a
fast click: a normal press and a double_click press, both in the same frame.
The previous _gui_input emitted card_pressed for both, so the first emission
selected the card and the second (double_click) immediately deselected it.
Fix:
- Skip card_pressed emission when event.double_click is true
- Consume RELEASE as well as PRESS so neither can leak to the 3D board's
_unhandled_input handler (belt-and-suspenders over the _press_was_on_board
guard that already exists in game_screen.gd)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- _add_highlight: use emission (emission_energy_multiplier=2) + 75% opaque base
so tiles glow visibly regardless of depth-sort/transparency ordering; raised
Y to 0.58 (clear of tile top at 0.50); thicker mesh (0.06 vs 0.02)
- Remove Godot-3-only flags_transparent property (no-op in Godot 4)
- _on_state_updated: preserve CARD_FROM_HAND / TERRAMORPHA_SELECT through server
state pushes if selected card is still in hand (re-apply highlights after
_rebuild_hand); only clear UNIT_SELECTED and other transient modes
- Add diagnostic prints to _add_highlight and _on_state_updated to trace when
state updates arrive relative to card selection
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Spirit tile null safety: dict.get(key, default) only uses the default when
the key is absent. Server sends nullable ints as JSON null, so the key EXISTS
but the value is null. GDScript returns null which coerces to 0 on a typed int,
collapsing min_r/max_r to 0 and producing zero valid tiles. Fixed by reading
channel range as Variant and substituting the default (1/2) when null.
- Channel range source: read from arch (ArchSpirit), not the Spirit card — the
ArchSpirit defines how far away from itself it can channel Spirits.
- Ruin: auto-placed by server. Clicking a Ruin card now immediately calls
send_play_card without entering CARD_FROM_HAND mode or requiring a tile click.
Added Ruin to the board-click immediate-play guard as well.
- Deselect previous: before entering a new CARD_FROM_HAND selection, explicitly
call _set_mode(NONE) when already in CARD_FROM_HAND or TERRAMORPHA_SELECT.
This guarantees _refresh_hand_selection fires a deselect tween on the old
card before the new card's select tween begins.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Spirit/Ruin valid tiles: channel range was read from arch (archSpirit) instead
of card (the Spirit being played). Fixed to card.get("minChannelRange", 1) /
card.get("maxChannelRange", 2). Also restored "Ruin" to the tile-target branch
(it needs a tile target, not the no-target branch).
- Terramorpha: skip entering TERRAMORPHA_SELECT if currentSp < spCost. Player
can see their SP in the HUD; clicking an unaffordable card does nothing.
- Hand card tween: removed mouse_entered/mouse_exited hover animation. Tween
now fires only on selection state change in _refresh_hand_selection, tracking
previous state via "_sel" widget metadata.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Input bug: CardWidget only consumed mouse PRESS via accept_event(), not RELEASE.
This caused _unhandled_input to fire _handle_board_click on release of a card
click, hitting the tile physically behind the hand area in 3D — accidentally
sending play_card to the wrong tile (Spirit/Ruin) or picking the first tile for
Terramorpha. Fixed by tracking _press_was_on_board: board clicks only fire when
the originating PRESS also reached _unhandled_input (i.e., was not consumed by
a UI card widget).
- Server: added SpCost, StCost, Genus, MinChannelRange, MaxChannelRange,
MinAttackRange, MaxAttackRange, CanMove, CanAttack, ExtraAttacksRemaining,
CanBeAttacked, AbilitiesJson to CardInstanceDto and ToCardDto mapping.
All fields were already on CardInstance; they were simply not exposed to clients.
- Client: build def dict in _make_hand_card with maxMp → movementPoints alias
so CardWidget displays movement points correctly.
- Client: show MetaRow (genus + type) in compact hand card; only StatsGrid is
hidden. HandArea / RightPanel height raised 190 → 220px for better visibility.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Two root causes broke unit movement and card play:
1. Camera yaw=180° for P1 pushed P1's own row to the bottom of the 3D
projection, directly behind the 260px HandArea panel → tiles unreachable
2. HandArea grew from 180→260px, blocking even more of the lower board
Fixes:
- Compact CardWidget in hand: hide MetaRow + StatsGrid, shrink ArtArea
min height to 80px → card ~150px, fits in 190px HandArea
- HandArea / RightPanel height: 260→190px
- Camera orientation: when setting yaw for P1/P2, also shift _cam_pivot
30% of board half-length toward the player's own side so their row
sits mid-screen (above the HandArea), not hidden behind it
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Hand display:
- Replace bespoke _make_hand_card() with CardWidget.tscn (the shared collection
card widget) — shows art, stats, affinity border, SP/ST costs
- Pass live game card dict as both dto and def; all camelCase fields match
- _refresh_hand_selection() now calls widget.set_selected() instead of
manipulating StyleBoxFlat directly
- HandArea/RightPanel height 180 → 260px to fit CardWidget (238px natural height)
- HBoxContainer separation -12 (overlap) → 6px (proper spacing)
Terramorpha tile selection (Dimorpha / Trimorpha):
- After each tile pick, re-highlight: orange for already-selected tiles, green
for valid adjacent tiles for the next pick — no more silent rejection of
non-adjacent clicks
Attack range visualization:
- _attack_range_tiles(): returns all tiles within minAttackRange–maxAttackRange
for units with maxRange > 1 (ranged spirits)
- _select_unit() shows orange range area first, then red on top for actual
attackable enemies — players can now see a ranged unit's full reach
Camera orientation:
- On first state that includes playerOneAccountId, orient camera behind the
local player's row: P1 (row 0, world -Z) gets yaw=180°, P2 keeps yaw=0°
- _camera_oriented flag ensures this only runs once per scene entry
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
SaveStateAsync was serializing GameState BEFORE incrementing NextActionSequence,
so the written StateJson always had the pre-increment value. Every subsequent
request read the same NextActionSequence and computed the same SequenceNumber,
causing duplicate key violations on IX_action_logs_GameSessionId_SequenceNumber
even in purely sequential scenarios (e.g. P2 places then P1 places).
Fix: increment NextActionSequence first, then serialize, so the persisted JSON
always reflects the sequence number that was just consumed.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
NatsUtf8PrimitivesSerializer (the default) can only handle primitives and
strings, causing "Can't serialize GameStartedEvent" at runtime.
Add NatsJsonSerializer<T> implementing INatsSerialize<T>/INatsDeserialize<T>
using System.Text.Json, and pass it explicitly to PublishAsync/SubscribeAsync
in NatsEventBus so all custom NATS event payloads serialize as JSON.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- LoadActiveSessionAsync: begin explicit transaction + lock session row
with SELECT FOR UPDATE so concurrent handlers for the same session
queue up instead of racing
- SaveStateAsync: commit (and release) the transaction after EF SaveChanges
fixes duplicate key on IX_action_logs_GameSessionId_SequenceNumber
when both players act simultaneously (e.g. both placing ArchSpirits)
- GameRules: default board size 9x9 (was 8x8)
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
activePlayerAccountId stays as P1 for the entire Placement phase, so
P2 always saw "waiting for opponent". Now each player checks whether
their own ArchSpirit has been placed to decide which UI to show.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
- Block unit selection in Placement phase (prevents sending game.move_unit
when opponent hasn't placed yet)
- All accountId comparisons now case-insensitive (Guid serialization may
differ between auth response and state DTO)
- Add debug log in _on_state_updated: phase, player found, hand size
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>