Previously, pausing effects (CloneSpiritAsToken/TargetTile,
ChannelCardFromZone/TargetTile+Choice, StackDeck interactive) only stored
the outer action-sequence continuation. Any effects after the pausing one on
the same target, and any remaining targets in the same action, were silently
dropped on resume. This commit makes pause/resume fully general.
Mechanism:
- New IntraActionStep private class: { TargetRef, EffectsJson }
- BuildIntraActionContinuationJson(currentTarget, ctx) captures:
• remaining effects on the paused target (effects[effectIndex+1..])
• all effects applied to each remaining target (targets[targetIndex+1..])
- ApplyIntraActionContinuation applies those steps at resume time before
the outer continuation actions
- FindTargetByRef / GetTargetRef round-trip any resolved target type
(FieldCard, CardInstance, PlayerState, Coord) through a string ref
AbilityContext gains 5 per-iteration tracking fields set by ExecuteSingleAction:
CurrentEffectIndex, CurrentTargetIndex, CurrentActionTargets,
CurrentActionAllEffects, CurrentActionDuration
ExecuteSingleAction target/effect loops converted from foreach to indexed
for-loops so ctx position fields stay in sync with each ExecuteEffect call.
IntraActionContinuationJson added to PendingTilePick, PendingPlayerPick,
and PendingRevealChoicePick. All three pause-emitting cases (CloneSpiritAsToken,
ChannelCardFromZone x2, StackDeck) populate it. All three resume methods
(ResumeTilePick, ResumePlayerPick, ResumeRevealChoicePick) call
ApplyIntraActionContinuation before executing outer continuation.
ChannelCardFromZone player-pick-to-tile-pick chain now forwards
IntraActionContinuationJson so it survives a double-pause sequence.
The "DESIGN CONSTRAINT: pausing effects must be terminal" comment is removed
as it is no longer true.
Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
SOR
Resources
In addition to this gitea repository, the application's servers and webclient are deployed using containers using ArgoCD.
Installation Instructions
Visual Studio Code
Download any version of Visual Studio Code, from here:
Godot Version 4.5.x
Download a version of Godot 4.5.x, preferrably Godot 4.5.2-stable, from here:
The Godot executable doesn't require an installation. Just unzip the godot folder and run the 'Godot_v4.5.2-stable_win64' executable.
Clone Instructions
Only HTTPS clone to VSCode is supported at the moment.
- SSH Clone doesn't work since the repository root doesn't have a .git folder.
On the "Code" page for SOR, click the "Code" button and then click "Open with VS Code".
- Your browser may ask if you want to launch VS Code. Do so.
- VS Code will utilize your browser to authenticate. Do so.
The Client
The Client is a GUI created in Godot.
Modifying the Client in Godot
Once you've cloned the repository, Open Godot.
Then, select "Import".
Open the project.godot file in the Client/origin-client/ folder.
Building the Web Client
When you update the 'main' branch of the SOR Repository, a gitea action will automatically start, building the Godot Web Client.
Deploying the Web Client
After the Web Client is built, you need to restart (not sync) the Deployment object of the sor-webclient application in ArgoCD.
