Same failure signature as the boss test fixed last round ("Test
timeout of 45000ms exceeded", the whole test's hard deadline, not a
specific assertion), this time landing on this test instead -- not
caused by the Helm chart fix or the boss test.slow() change, both of
which touch entirely disjoint code (a Kubernetes manifest template
never exercised by npm run test:e2e, and a different test block).
Consistent with a CI runner that's intermittently slow enough that
whichever test draws the short straw on a given run can blow its
budget before its own poll timeout gets to report cleanly -- this is
the most elaborate test here (WebGL pixel readback, model diagnostics,
a full reload/reconnect cycle), so the most likely next candidate.
Verified: full local e2e suite (7/7) still passes.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Latest CI failure was a different signature than anything the retry
fix addresses: "Test timeout of 45000ms exceeded" -- the whole test's
hard deadline, not the specific 20s poll assertion (which has its own
budget and, per the retry fix, gives up cleanly well within it). That
means cumulative time for enter() + awakening the boss + closing
settings is eating far enough into the config's 45s per-test timeout
on a slow run that the poll never gets the chance to report on its own
terms before the whole test gets killed.
test.slow() triples this one test's timeout (45s -> 135s) rather than
inflating the config's global timeout for every test. Confirmed the
retry-logic fix from two rounds ago (which passed on CI last round) is
untouched here -- this is purely a timeout-budget change layered on
top of it.
Verified: full local e2e suite (7/7) still passes.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Re-applying the independently-diagnosed Helm bug fix that got reverted
along with everything else a few rounds back (flagged at the time that
CI would hit this again the moment it wasn't reapplied -- it just did).
helm lint deploy/chart (the default 5-world values.yaml) fails:
templates/worlds.yaml: unable to parse YAML: error converting YAML
to JSON: yaml: line 24: did not find expected key
Root cause (confirmed earlier via `helm template --debug` on the raw,
pre-parse output): the per-world loop's `{{- $host := ... -}}` line has
a leading whitespace-trim that eats the one newline separating one
world's rendered manifests from the next world's "---" separator, so
consecutive iterations run together as "...port: { name: http } }---
apiVersion: apps/v1" with no newline -- invalid YAML. values-srs.yaml
only has one world, so the loop never repeats and never trips this;
the default values.yaml has five.
Fix: drop the leading trim (`{{-` -> `{{`) on just that line, so the
one separating newline survives.
Verified with the same helm v4.2.4 CI uses: `helm lint`/`helm template`
clean against both deploy/chart's default values (5 worlds) and
-f deploy/values-srs.yaml (1 world); rendered manifests for all 5
worlds look correct.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Testing this in isolation from the anti-throttle Chromium flags and
the DB-lock change (reverted separately, ruled out on its own): the
single fire-and-forget gather/attack action has no recovery if the one
evaluated frame doesn't line up with the authoritative server position
-- confirmed by live-instrumenting the unpatched code locally and
watching it hang. This reinstates the fix from the earlier round, with
both bugs found via live diagnostic testing already fixed going in:
- Retries at a conservative cadence (~0.3s, well under the intent rate
limit) instead of firing once and giving up forever.
- Gives up on a target only once an actual progress signal (target HP
for attack, held-item count for gather/loot) has stopped moving for
a wall-clock budget -- not "hasn't succeeded since the click" (which
wrongly aborts mid-fight during a normal cooldown lull) and not a
frame/attempt count (which balloons into tens of real seconds on a
tab with sparse rendered frames).
- The dedicated boss-attack button now also resets the progress clock;
it used to bypass action() entirely and read an uninitialized clock,
immediately abandoning the boss for the nearest mob on click.
Deliberately NOT re-adding the Chromium anti-throttle flags this round
-- keeping this an isolated variable after the last round's session
crash coincided with adding them.
Also bumped one unrelated, independently-diagnosed timeout: the
post-death new-character join in portal.spec.ts was polling on
Playwright's default 5s timeout for a fresh join's first snapshot,
with no connection to the retry logic above.
Verified: tsc/build clean, three full local e2e runs (7/7 each).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>