Initialize optional input on legacy actions
Foundation / checks (ecs) (push) Successful in 1m55s
Foundation / checks (tsan) (push) Canceled after 0s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (postgres) (push) Canceled after 1m3s
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (network) (push) Failing after 10m12s
Foundation / checks (client) (push) Canceled after 13m15s
Foundation / checks (checks) (push) Canceled after 13m19s
Foundation / checks (ecs) (push) Successful in 1m55s
Foundation / checks (tsan) (push) Canceled after 0s
Foundation / postgres-tools (push) Canceled after 0s
Foundation / server-image (push) Canceled after 0s
Foundation / image (push) Canceled after 0s
Foundation / checks (postgres) (push) Canceled after 1m3s
Foundation / checks (deploy) (push) Successful in 5s
Foundation / checks (network) (push) Failing after 10m12s
Foundation / checks (client) (push) Canceled after 13m15s
Foundation / checks (checks) (push) Canceled after 13m19s
This commit is contained in:
@@ -6714,3 +6714,9 @@ in `ActionLedger::find_record`. The function now moves the inner optional to a
|
||||
local, checks its state, and unwraps only after that check. This is an existing
|
||||
network-ledger warning exposed by the full network target; full CI is pending
|
||||
for the combined repairs.
|
||||
|
||||
Run 245 confirms that optional-access fix removes its clang-tidy failure, then
|
||||
reports two `-Wmissing-field-initializers` errors for legacy probe actions after
|
||||
`CarriedAction` gained its optional cellular input. Those probe records now set
|
||||
that input to `std::nullopt` explicitly; run 245 stopped before network tests.
|
||||
The combined repairs are queued for a new full CI run.
|
||||
|
||||
@@ -230,7 +230,7 @@ ActionReceipt IntentAdmission::action(std::uint64_t session, const SessionAction
|
||||
decide(s->account, r, lookup(s->account, m.action_id));
|
||||
if (r.status == AdmitStatus::admitted)
|
||||
actions_.push_back(
|
||||
{{s->account, m.action_id, m.tick, ActionKind::probe}, Stage::scheduled});
|
||||
{{s->account, m.action_id, m.tick, ActionKind::probe, std::nullopt}, Stage::scheduled});
|
||||
return r;
|
||||
}
|
||||
|
||||
@@ -264,7 +264,7 @@ std::optional<ActionReceipt> IntentAdmission::admit(std::uint64_t session, const
|
||||
return r;
|
||||
// Held like an admitted action (duplicates and the unresolved limit see it), but never
|
||||
// carried until `verify` confirms it.
|
||||
actions_.push_back({{s->account, m.action_id, m.tick, ActionKind::probe},
|
||||
actions_.push_back({{s->account, m.action_id, m.tick, ActionKind::probe, std::nullopt},
|
||||
check ? Stage::verifying : Stage::scheduled,
|
||||
false,
|
||||
session,
|
||||
|
||||
Reference in New Issue
Block a user